-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use javax.annotation.Nullable instead of androidx.annotation.Nullable to decouple Android dependency #23310
Use javax.annotation.Nullable instead of androidx.annotation.Nullable to decouple Android dependency #23310
Conversation
PR #23310: Size comparison from 252aad1 to 5bf9d1a Increases (3 builds for bl602, bl702, psoc6)
Decreases (5 builds for esp32, psoc6, qpg, telink)
Full report (38 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #23310: Size comparison from 252aad1 to 3985598 Increases (5 builds for bl702, psoc6, telink)
Decreases (9 builds for bl702, esp32, psoc6, qpg, telink)
Full report (49 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
LGTM! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
PR #23310: Size comparison from 0998742 to d77adf7 Increases (4 builds for bl602, cc13x2_26x2, cyw30739)
Decreases (8 builds for bl602, cc13x2_26x2, k32w, psoc6, qpg, telink)
Full report (49 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #23310: Size comparison from db11e29 to 239b254 Increases (4 builds for bl602, esp32, k32w, qpg)
Decreases (6 builds for bl602, esp32, nrfconnect, psoc6, qpg, telink)
Full report (49 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #23310: Size comparison from 0d6c60f to a2d365b Increases (6 builds for cc13x2_26x2, esp32, nrfconnect, psoc6)
Decreases (8 builds for bl602, bl702, cc13x2_26x2, psoc6, telink)
Full report (38 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #23310: Size comparison from 0d6c60f to 7ef307c Increases (7 builds for bl602, cc13x2_26x2, esp32, nrfconnect, psoc6)
Decreases (7 builds for bl602, cc13x2_26x2, psoc6, telink)
Full report (38 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
… to decouple Android dependency (project-chip#23310) * Use JSR305 Annotations instead of Android:annotations * Address review comments
… to decouple Android dependency (project-chip#23310) * Use JSR305 Annotations instead of Android:annotations * Address review comments
#23811
Currently, androidx.annotation.Nullable is used in Matter Controller Java package, this prevent us from using matter java package in a Java application running on desktop.
Replace androidx.annotation.Nullable with javax.annotation.Nullable
Testing:
Build both Adnroid CHIPTool and java-matter-controller, and running on Android phone and Linux, no regression found.