Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Missing Support for Project-specific Configuration for Various Layer Libraries and the Stack #224

Merged
merged 3 commits into from
Apr 3, 2020
Merged

Add Missing Support for Project-specific Configuration for Various Layer Libraries and the Stack #224

merged 3 commits into from
Apr 3, 2020

Conversation

gerickson
Copy link
Contributor

Problem

A number of stack layer/subsystem libraries and the overall stack at large allow project- or target-specific configuration to override the defaults for those layers/subsystem libraries or the stack.

Unfortunately, the build system has no way for the project user to specify those overrides.

Summary of Changes

  • Migrate-in options for the user to specify project-specific configuration files for various CHIP subsystem libraries and the overall stack.
  • Re-enable previously-disabled configuration code now that the dependent subsystems are in-project.

Fixes #217

Grant Erickson added 3 commits April 2, 2020 11:03
@gerickson
Copy link
Contributor Author

Please note that this depends on landing pull request #221 for this to successfully land and build.

@gerickson
Copy link
Contributor Author

@hawk248 or @jelderton; @tpmanley or @BroderickCarlin; @woody-apple or @anush-apple?

rwalker-apple
rwalker-apple reviewed Apr 3, 2020
View reviewed changes
Copy link
Contributor

@rwalker-apple rwalker-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@woody-apple woody-apple merged commit bffe3db into project-chip:master Apr 3, 2020
mkardous-silabs referenced this pull request in mkardous-silabs/connectedhomeip Nov 2, 2022
@rerasool
Pull request #229: Cherry-Pick "Wi-Fi CI Failure Bug Fix" from silabs…
6f436df 
… to silabs_1.0

Merge in WMN_TOOLS/matter from cherry-pick/jenkins_wifi_ci_fix to silabs_1.0

Squashed commit of the following:

commit b429e95000464dd5f10968b54988f1a5ed7f8f5c
Author: Manav Mehta <Manav.Mehta@silabs.com>
Date:   Thu Oct 27 13:06:01 2022 +0000

    Pull request #224: Wi-Fi CI Failure Bug Fix

    Merge in WMN_TOOLS/matter from bugfix/jenkins_wifi_ci_fix to silabs

    Squashed commit of the following:

    commit 730d6f4c2f7a5ceae6d5bc0e600e0cf9483d9beb
    Author: Manav Mehta <Manav.Mehta@silabs.com>
    Date:   Thu Oct 27 07:19:21 2022 +0000

        Jenkinsfile edited online with Bitbucket

        Fixed CI failure
mkardous-silabs referenced this pull request in mkardous-silabs/connectedhomeip May 2, 2023
@jmartinez-silabs
Pull request #224: Wi-Fi CI Failure Bug Fix
18282a0 
Merge in WMN_TOOLS/matter from bugfix/jenkins_wifi_ci_fix to silabs

Squashed commit of the following:

commit 730d6f4c2f7a5ceae6d5bc0e600e0cf9483d9beb
Author: Manav Mehta <Manav.Mehta@silabs.com>
Date:   Thu Oct 27 07:19:21 2022 +0000

    Jenkinsfile edited online with Bitbucket

    Fixed CI failure
shgutte pushed a commit to shgutte/connectedhomeip that referenced this pull request Oct 5, 2023
@jmartinez-silabs
Pull request project-chip#224: Wi-Fi CI Failure Bug Fix
2767da9 
Merge in WMN_TOOLS/matter from bugfix/jenkins_wifi_ci_fix to silabs

Squashed commit of the following:

commit 730d6f4c2f7a5ceae6d5bc0e600e0cf9483d9beb
Author: Manav Mehta <Manav.Mehta@silabs.com>
Date:   Thu Oct 27 07:19:21 2022 +0000

    Jenkinsfile edited online with Bitbucket

    Fixed CI failure
shgutte pushed a commit to shgutte/connectedhomeip that referenced this pull request Jan 11, 2024
@jmartinez-silabs
Pull request project-chip#224: Wi-Fi CI Failure Bug Fix
aa6f458 
Merge in WMN_TOOLS/matter from bugfix/jenkins_wifi_ci_fix to silabs

Squashed commit of the following:

commit 730d6f4c2f7a5ceae6d5bc0e600e0cf9483d9beb
Author: Manav Mehta <Manav.Mehta@silabs.com>
Date:   Thu Oct 27 07:19:21 2022 +0000

    Jenkinsfile edited online with Bitbucket

    Fixed CI failure
mkardous-silabs referenced this pull request in mkardous-silabs/connectedhomeip Jan 29, 2024
@jmartinez-silabs
Pull request #224: Wi-Fi CI Failure Bug Fix
b65e31d 
Merge in WMN_TOOLS/matter from bugfix/jenkins_wifi_ci_fix to silabs

Squashed commit of the following:

commit 730d6f4c2f7a5ceae6d5bc0e600e0cf9483d9beb
Author: Manav Mehta <Manav.Mehta@silabs.com>
Date:   Thu Oct 27 07:19:21 2022 +0000

    Jenkinsfile edited online with Bitbucket

    Fixed CI failure
mkardous-silabs referenced this pull request in mkardous-silabs/connectedhomeip Jan 29, 2024
@jmartinez-silabs
Pull request #224: Wi-Fi CI Failure Bug Fix
bcb7848 
Merge in WMN_TOOLS/matter from bugfix/jenkins_wifi_ci_fix to silabs

Squashed commit of the following:

commit 730d6f4c2f7a5ceae6d5bc0e600e0cf9483d9beb
Author: Manav Mehta <Manav.Mehta@silabs.com>
Date:   Thu Oct 27 07:19:21 2022 +0000

    Jenkinsfile edited online with Bitbucket

    Fixed CI failure
rcasallas-silabs pushed a commit to rcasallas-silabs/connectedhomeip that referenced this pull request Jun 20, 2024
@jmartinez-silabs
Pull request project-chip#224: Wi-Fi CI Failure Bug Fix
a43ce81 
Merge in WMN_TOOLS/matter from bugfix/jenkins_wifi_ci_fix to silabs

Squashed commit of the following:

commit 730d6f4c2f7a5ceae6d5bc0e600e0cf9483d9beb
Author: Manav Mehta <Manav.Mehta@silabs.com>
Date:   Thu Oct 27 07:19:21 2022 +0000

    Jenkinsfile edited online with Bitbucket

    Fixed CI failure
rcasallas-silabs pushed a commit to rcasallas-silabs/connectedhomeip that referenced this pull request Jun 20, 2024
@jmartinez-silabs
Pull request project-chip#224: Wi-Fi CI Failure Bug Fix
b2a148c 
Merge in WMN_TOOLS/matter from bugfix/jenkins_wifi_ci_fix to silabs

Squashed commit of the following:

commit 730d6f4c2f7a5ceae6d5bc0e600e0cf9483d9beb
Author: Manav Mehta <Manav.Mehta@silabs.com>
Date:   Thu Oct 27 07:19:21 2022 +0000

    Jenkinsfile edited online with Bitbucket

    Fixed CI failure
mykrupp pushed a commit to mykrupp/connectedhomeip that referenced this pull request Jul 18, 2024
@jmartinez-silabs
Pull request project-chip#224: Wi-Fi CI Failure Bug Fix
d802db0 
Merge in WMN_TOOLS/matter from bugfix/jenkins_wifi_ci_fix to silabs

Squashed commit of the following:

commit 730d6f4c2f7a5ceae6d5bc0e600e0cf9483d9beb
Author: Manav Mehta <Manav.Mehta@silabs.com>
Date:   Thu Oct 27 07:19:21 2022 +0000

    Jenkinsfile edited online with Bitbucket

    Fixed CI failure
lpbeliveau-silabs pushed a commit to lpbeliveau-silabs/connectedhomeip that referenced this pull request Jan 27, 2025
@mkardous-silabs
[SL-TEMP] Add custom silabs worklfows to build sample apps (project-c…
4aef509 
…hip#178) (project-chip#224)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwalker-apple rwalker-apple rwalker-apple left review comments

@BroderickCarlin BroderickCarlin BroderickCarlin approved these changes

@woody-apple woody-apple woody-apple approved these changes

@jelderton jelderton jelderton approved these changes

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@pan-apple pan-apple Awaiting requested review from pan-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@hawk248 hawk248 Awaiting requested review from hawk248

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@tpmanley tpmanley Awaiting requested review from tpmanley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Missing Support for Project-specific Configuration for Various Layer Libraries and the Stack
5 participants
@gerickson @BroderickCarlin @woody-apple @rwalker-apple @jelderton