Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update even more cluster access privileges #17134

Merged
merged 1 commit into from
Apr 6, 2022
Merged

Update even more cluster access privileges #17134

merged 1 commit into from
Apr 6, 2022

Conversation

mlepage-google
Copy link
Contributor

Problem

Issue #14419 more clusters need custom required privilege

Change overview

Update more cluster access privileges

In general.xml:

  • Groups
  • Scenes
  • LevelControl

In ha.xml:

  • ThermostatUserInterfaceConfiguration
  • ColorControl
  • OccupancySensing

Testing

  • ZAP regen, build, CI
  • Review generated access.h

@mlepage-google
More cluster access privileges updated
3b31a87 
In general.xml:
- Groups
- Scenes
- LevelControl

In ha.xml:
- ThermostatUserInterfaceConfiguration
- ColorControl
- OccupancySensing
@boring-cyborg boring-cyborg bot added the app label Apr 6, 2022
@mlepage-google
Copy link
Contributor Author

mlepage-google commented Apr 6, 2022 •
edited
Loading

I figured this would update separate clusters from PR #17115, but in retrospect I'll probably still have to rebase if they share any generated files.

@mlepage-google mlepage-google changed the title More cluster access privileges updated Update even more cluster access privileges Apr 6, 2022
@mlepage-google mlepage-google mentioned this pull request Apr 6, 2022
Closed
@github-actions
Copy link

github-actions bot commented Apr 6, 2022 •
edited
Loading

PR #17134: Size comparison from 6da0db8 to 3b31a87

Increases (16 builds for cc13x2_26x2, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
platform target config section 6da0db8 3b31a87 change % change
cc13x2_26x2 pump-app LP_CC2652R7 (read only) 691607 691687 80 0.0
.rodata 82511 82591 80 0.1
pump-controller-app LP_CC2652R7 (read only) 675979 676011 32 0.0
.rodata 79011 79043 32 0.0
efr32 lighting-app BRD4161A (read only) 904532 904588 56 0.0
.text 904524 904580 56 0.0
BRD4161A+rpc (read only) 932420 932476 56 0.0
.text 932412 932468 56 0.0
esp32 all-clusters-app c3devkit (read only) 991668 991670 2 0.0
(read/write) 1461530 1461738 208 0.0
.flash.rodata 198784 198992 208 0.1
.flash.text 991668 991670 2 0.0
m5stack (read/write) 462584 462792 208 0.0
.flash.rodata 227848 228056 208 0.1
k32w light k32w061+release (read/write) 684828 684884 56 0.0
.text 598800 598856 56 0.0
linux all-clusters-app debug (read only) 2617705 2617929 224 0.0
.rodata 222149 222373 224 0.1
lighting-app debug+rpc (read only) 2277625 2277689 64 0.0
.rodata 180553 180617 64 0.0
shell debug (read only) 2513177 2513401 224 0.0
.rodata 213874 214098 224 0.1
thermostat-no-ble arm64 (read only) 2344188 2344260 72 0.0
.rodata 144364 144436 72 0.0
tv-app debug (read only) 2787361 2787393 32 0.0
.rodata 212523 212555 32 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1152967 1153175 208 0.0
rodata 145632 145840 208 0.1
p6 all-clusters-app default (read/write) 2511992 2512200 208 0.0
.text 1470256 1470464 208 0.0
light-app default (read/write) 2413168 2413216 48 0.0
.text 1371432 1371480 48 0.0
telink lighting-app tlsr9518adk80d (read/write) 798836 798888 52 0.0
Decreases (2 builds for cc13x2_26x2)
platform target config section 6da0db8 3b31a87 change % change
cc13x2_26x2 pump-app LP_CC2652R7 (read/write) 161064 160984 -80 -0.0
pump-controller-app LP_CC2652R7 (read/write) 176436 176404 -32 -0.0
Full report (28 builds for cc13x2_26x2, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 6da0db8 3b31a87 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 674307 674307 0 0.0
(read/write) 177204 177204 0 0.0
.bss 81552 81552 0 0.0
.data 3168 3168 0 0.0
.rodata 80579 80579 0 0.0
.text 593248 593248 0 0.0
lock-mtd LP_CC2652R7 (read only) 623443 623443 0 0.0
(read/write) 154304 154304 0 0.0
.bss 77280 77280 0 0.0
.data 3168 3168 0 0.0
.rodata 80467 80467 0 0.0
.text 542488 542488 0 0.0
pump-app LP_CC2652R7 (read only) 691607 691687 80 0.0
(read/write) 161064 160984 -80 -0.0
.bss 81944 81944 0 0.0
.data 3200 3200 0 0.0
.rodata 82511 82591 80 0.1
.text 608612 608612 0 0.0
pump-controller-app LP_CC2652R7 (read only) 675979 676011 32 0.0
(read/write) 176436 176404 -32 -0.0
.bss 81688 81688 0 0.0
.data 3164 3164 0 0.0
.rodata 79011 79043 32 0.0
.text 596484 596484 0 0.0
efr32 lighting-app BRD4161A (read only) 904532 904588 56 0.0
(read/write) 133144 133144 0 0.0
.bss 131152 131152 0 0.0
.data 1992 1992 0 0.0
.text 904524 904580 56 0.0
BRD4161A+rpc (read only) 932420 932476 56 0.0
(read/write) 149092 149092 0 0.0
.bss 146920 146920 0 0.0
.data 2172 2172 0 0.0
.text 932412 932468 56 0.0
window-app BRD4161A (read only) 841868 841868 0 0.0
(read/write) 131204 131204 0 0.0
.bss 129328 129328 0 0.0
.data 1876 1876 0 0.0
.text 841860 841860 0 0.0
esp32 all-clusters-app c3devkit (read only) 991668 991670 2 0.0
(read/write) 1461530 1461738 208 0.0
.dram0.bss 63000 63000 0 0.0
.dram0.data 14260 14260 0 0.0
.flash.rodata 198784 198992 208 0.1
.flash.text 991668 991670 2 0.0
.iram0.text 62572 62572 0 0.0
m5stack (read only) 1044367 1044367 0 0.0
(read/write) 462584 462792 208 0.0
.dram0.bss 68528 68528 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 227848 228056 208 0.1
.flash.text 1038983 1038983 0 0.0
.iram0.text 123415 123415 0 0.0
k32w light k32w061+release (read/write) 684828 684884 56 0.0
.bss 78240 78240 0 0.0
.data 1988 1988 0 0.0
.text 598800 598856 56 0.0
lock k32w061+release (read/write) 689668 689668 0 0.0
.bss 78816 78816 0 0.0
.data 1948 1948 0 0.0
.text 603104 603104 0 0.0
linux all-clusters-app debug (read only) 2617705 2617929 224 0.0
(read/write) 145384 145384 0 0.0
.bss 57856 57856 0 0.0
.data 1408 1408 0 0.0
.data.rel.ro 80232 80232 0 0.0
.dynamic 592 592 0 0.0
.got 4312 4312 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 222149 222373 224 0.1
.text 2226866 2226866 0 0.0
bridge-app debug+rpc (read only) 1826845 1826845 0 0.0
(read/write) 90824 90824 0 0.0
.bss 44792 44792 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 38904 38904 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 148409 148409 0 0.0
.text 1561157 1561157 0 0.0
chip-tool debug (read only) 10675813 10675813 0 0.0
(read/write) 371640 371640 0 0.0
.bss 22784 22784 0 0.0
.data 1040 1040 0 0.0
.data.rel.ro 341584 341584 0 0.0
.dynamic 624 624 0 0.0
.got 4928 4928 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 538005 538005 0 0.0
.text 9309013 9309013 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 10278220 10278220 0 0.0
(read/write) 492033 492033 0 0.0
.bss 41041 41041 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 388704 388704 0 0.0
.dynamic 560 560 0 0.0
.got 57360 57360 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 512396 512396 0 0.0
.text 8663044 8663044 0 0.0
door-lock-app debug (read only) 2098057 2098057 0 0.0
(read/write) 118864 118864 0 0.0
.bss 48128 48128 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 64024 64024 0 0.0
.dynamic 592 592 0 0.0
.got 4256 4256 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 186441 186441 0 0.0
.text 1757154 1757154 0 0.0
lighting-app debug+rpc (read only) 2277625 2277689 64 0.0
(read/write) 125920 125920 0 0.0
.bss 49472 49472 0 0.0
.data 1600 1600 0 0.0
.data.rel.ro 69160 69160 0 0.0
.dynamic 608 608 0 0.0
.got 4304 4304 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 180553 180617 64 0.0
.text 1933122 1933122 0 0.0
ota-provider-app debug (read only) 2036033 2036033 0 0.0
(read/write) 114432 114432 0 0.0
.bss 47968 47968 0 0.0
.data 1384 1384 0 0.0
.data.rel.ro 59352 59352 0 0.0
.dynamic 608 608 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 172291 172291 0 0.0
.text 1708370 1708370 0 0.0
ota-requestor-app debug (read only) 2065617 2065617 0 0.0
(read/write) 117720 117720 0 0.0
.bss 48928 48928 0 0.0
.data 1608 1608 0 0.0
.data.rel.ro 61592 61592 0 0.0
.dynamic 592 592 0 0.0
.got 4296 4296 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 168820 168820 0 0.0
.text 1739650 1739650 0 0.0
shell debug (read only) 2513177 2513401 224 0.0
(read/write) 148912 148912 0 0.0
.bss 67560 67560 0 0.0
.data 848 848 0 0.0
.data.rel.ro 74776 74776 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 213874 214098 224 0.1
.text 2140098 2140098 0 0.0
thermostat-no-ble arm64 (read only) 2344188 2344260 72 0.0
(read/write) 150257 150257 0 0.0
.bss 63169 63169 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 78184 78184 0 0.0
.dynamic 560 560 0 0.0
.got 4752 4752 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 144364 144436 72 0.0
.text 1972672 1972672 0 0.0
tv-app debug (read only) 2787361 2787393 32 0.0
(read/write) 250488 250488 0 0.0
.bss 165576 165576 0 0.0
.data 3360 3360 0 0.0
.data.rel.ro 75360 75360 0 0.0
.dynamic 592 592 0 0.0
.got 4672 4672 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 212523 212555 32 0.0
.text 2395362 2395362 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2366580 2366580 0 0.0
.bss 185092 185092 0 0.0
.data 5792 5792 0 0.0
.text 1329180 1329180 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1152967 1153175 208 0.0
bss 135604 135604 0 0.0
rodata 145632 145840 208 0.1
text 793156 793156 0 0.0
p6 all-clusters-app default (read/write) 2511992 2512200 208 0.0
.bss 118528 118528 0 0.0
.data 2672 2672 0 0.0
.text 1470256 1470464 208 0.0
light-app default (read/write) 2413168 2413216 48 0.0
.bss 111992 111992 0 0.0
.data 2528 2528 0 0.0
.text 1371432 1371480 48 0.0
lock-app default (read/write) 2376848 2376848 0 0.0
.bss 111736 111736 0 0.0
.data 2488 2488 0 0.0
.text 1335112 1335112 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 798836 798888 52 0.0
bss 70096 70096 0 0.0
noinit 40416 40416 0 0.0
text 567918 567918 0 0.0

@bzbarsky-apple bzbarsky-apple merged commit 48a1345 into project-chip:master Apr 6, 2022
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this pull request Apr 14, 2022
@mlepage-google @andrei-menzopol
More cluster access privileges updated (project-chip#17134)
48c960d 
In general.xml:
- Groups
- Scenes
- LevelControl

In ha.xml:
- ThermostatUserInterfaceConfiguration
- ColorControl
- OccupancySensing
@mlepage-google mlepage-google deleted the update-more-clusters-access branch April 28, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@msandstedt msandstedt Awaiting requested review from msandstedt

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mlepage-google @andy31415 @bzbarsky-apple