Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update more cluster access privileges #17115

Merged
merged 9 commits into from
Apr 7, 2022
Merged

Update more cluster access privileges #17115

merged 9 commits into from
Apr 7, 2022

Conversation

mlepage-google
Copy link
Contributor

@mlepage-google mlepage-google commented Apr 6, 2022 •
edited
Loading

Problem

Issue #14419 more clusters need custom required privilege

Change overview

  • Add access elements to cluster XML to match spec
  • Rename commissioning.xml to network-commissioning-cluster.xml
  • Rename thermostat "ac compressor" attribute to "ac compressor type"

Testing

  • ZAP regen, build, CI
  • Review generated access.h

@boring-cyborg boring-cyborg bot added the app label Apr 6, 2022
@github-actions
Copy link

github-actions bot commented Apr 6, 2022 •
edited
Loading

PR #17115: Size comparison from 56f738f to fbabaa5

Increases above 0.2%:

platform target config section 56f738f fbabaa5 change % change
cc13x2_26x2 pump-app LP_CC2652R7 .rodata 82511 82735 224 0.3
pump-controller-app LP_CC2652R7 .rodata 79011 79227 216 0.3
Increases (13 builds for cc13x2_26x2, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 56f738f fbabaa5 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 674307 674475 168 0.0
.rodata 80579 80731 152 0.2
.text 593248 593264 16 0.0
lock-mtd LP_CC2652R7 (read only) 623443 623611 168 0.0
.rodata 80467 80619 152 0.2
.text 542488 542504 16 0.0
pump-app LP_CC2652R7 (read only) 691607 691847 240 0.0
.rodata 82511 82735 224 0.3
.text 608612 608628 16 0.0
pump-controller-app LP_CC2652R7 (read only) 675979 676211 232 0.0
.rodata 79011 79227 216 0.3
.text 596484 596500 16 0.0
k32w light k32w061+release (read/write) 684828 685068 240 0.0
.text 598800 599040 240 0.0
lock k32w061+release (read/write) 689668 689852 184 0.0
.text 603104 603288 184 0.0
linux thermostat-no-ble arm64 (read only) 2344188 2344380 192 0.0
.rodata 144364 144556 192 0.1
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2366580 2366796 216 0.0
.text 1329180 1329396 216 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1152967 1153235 268 0.0
rodata 145632 145884 252 0.2
text 793156 793176 20 0.0
p6 all-clusters-app default (read/write) 2511992 2512216 224 0.0
.text 1470256 1470480 224 0.0
light-app default (read/write) 2413168 2413360 192 0.0
.text 1371432 1371624 192 0.0
lock-app default (read/write) 2376848 2376976 128 0.0
.text 1335112 1335240 128 0.0
telink lighting-app tlsr9518adk80d (read/write) 798836 799084 248 0.0
text 567918 567948 30 0.0
Decreases (3 builds for cc13x2_26x2)
platform target config section 56f738f fbabaa5 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read/write) 177204 177036 -168 -0.1
pump-app LP_CC2652R7 (read/write) 161064 160824 -240 -0.1
pump-controller-app LP_CC2652R7 (read/write) 176436 176204 -232 -0.1
Full report (14 builds for cc13x2_26x2, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 56f738f fbabaa5 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 674307 674475 168 0.0
(read/write) 177204 177036 -168 -0.1
.bss 81552 81552 0 0.0
.data 3168 3168 0 0.0
.rodata 80579 80731 152 0.2
.text 593248 593264 16 0.0
lock-mtd LP_CC2652R7 (read only) 623443 623611 168 0.0
(read/write) 154304 154304 0 0.0
.bss 77280 77280 0 0.0
.data 3168 3168 0 0.0
.rodata 80467 80619 152 0.2
.text 542488 542504 16 0.0
pump-app LP_CC2652R7 (read only) 691607 691847 240 0.0
(read/write) 161064 160824 -240 -0.1
.bss 81944 81944 0 0.0
.data 3200 3200 0 0.0
.rodata 82511 82735 224 0.3
.text 608612 608628 16 0.0
pump-controller-app LP_CC2652R7 (read only) 675979 676211 232 0.0
(read/write) 176436 176204 -232 -0.1
.bss 81688 81688 0 0.0
.data 3164 3164 0 0.0
.rodata 79011 79227 216 0.3
.text 596484 596500 16 0.0
k32w light k32w061+release (read/write) 684828 685068 240 0.0
.bss 78240 78240 0 0.0
.data 1988 1988 0 0.0
.text 598800 599040 240 0.0
lock k32w061+release (read/write) 689668 689852 184 0.0
.bss 78816 78816 0 0.0
.data 1948 1948 0 0.0
.text 603104 603288 184 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 10278220 10278220 0 0.0
(read/write) 492033 492033 0 0.0
.bss 41041 41041 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 388704 388704 0 0.0
.dynamic 560 560 0 0.0
.got 57360 57360 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 512396 512396 0 0.0
.text 8663044 8663044 0 0.0
thermostat-no-ble arm64 (read only) 2344188 2344380 192 0.0
(read/write) 150257 150257 0 0.0
.bss 63169 63169 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 78184 78184 0 0.0
.dynamic 560 560 0 0.0
.got 4752 4752 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 144364 144556 192 0.1
.text 1972672 1972672 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2366580 2366796 216 0.0
.bss 185092 185092 0 0.0
.data 5792 5792 0 0.0
.text 1329180 1329396 216 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1152967 1153235 268 0.0
bss 135604 135604 0 0.0
rodata 145632 145884 252 0.2
text 793156 793176 20 0.0
p6 all-clusters-app default (read/write) 2511992 2512216 224 0.0
.bss 118528 118528 0 0.0
.data 2672 2672 0 0.0
.text 1470256 1470480 224 0.0
light-app default (read/write) 2413168 2413360 192 0.0
.bss 111992 111992 0 0.0
.data 2528 2528 0 0.0
.text 1371432 1371624 192 0.0
lock-app default (read/write) 2376848 2376976 128 0.0
.bss 111736 111736 0 0.0
.data 2488 2488 0 0.0
.text 1335112 1335240 128 0.0
telink lighting-app tlsr9518adk80d (read/write) 798836 799084 248 0.0
bss 70096 70096 0 0.0
noinit 40416 40416 0 0.0
text 567918 567948 30 0.0

@mlepage-google
Fix thermostat cluster attribute name
198e21a 
Should be "ac compressor type" not "ac compressor" per spec.
@github-actions
Copy link

github-actions bot commented Apr 6, 2022 •
edited
Loading

PR #17115: Size comparison from 56f738f to 198e21a

Increases above 0.2%:

platform target config section 56f738f 198e21a change % change
cc13x2_26x2 pump-app LP_CC2652R7 .rodata 82511 82735 224 0.3
pump-controller-app LP_CC2652R7 .rodata 79011 79227 216 0.3
Increases (19 builds for cc13x2_26x2, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 56f738f 198e21a change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 674307 674475 168 0.0
.rodata 80579 80731 152 0.2
.text 593248 593264 16 0.0
lock-mtd LP_CC2652R7 (read only) 623443 623611 168 0.0
.rodata 80467 80619 152 0.2
.text 542488 542504 16 0.0
pump-app LP_CC2652R7 (read only) 691607 691847 240 0.0
.rodata 82511 82735 224 0.3
.text 608612 608628 16 0.0
pump-controller-app LP_CC2652R7 (read only) 675979 676211 232 0.0
.rodata 79011 79227 216 0.3
.text 596484 596500 16 0.0
efr32 lighting-app BRD4161A (read only) 923476 923676 200 0.0
.text 923468 923668 200 0.0
BRD4161A+rpc (read only) 951364 951564 200 0.0
.text 951356 951556 200 0.0
window-app BRD4161A (read only) 860796 860980 184 0.0
.text 860788 860972 184 0.0
esp32 all-clusters-app c3devkit (read only) 991668 991700 32 0.0
(read/write) 1461530 1461778 248 0.0
.dram0.data 14260 14268 8 0.1
.flash.rodata 198784 199032 248 0.1
.flash.text 991668 991700 32 0.0
m5stack (read only) 1043503 1043527 24 0.0
(read/write) 462488 462744 256 0.1
.flash.rodata 227752 228008 256 0.1
.flash.text 1038119 1038143 24 0.0
k32w light k32w061+release (read/write) 684828 685068 240 0.0
.text 598800 599040 240 0.0
lock k32w061+release (read/write) 689668 689852 184 0.0
.text 603104 603288 184 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 10278220 10278236 16 0.0
.rodata 512396 512412 16 0.0
thermostat-no-ble arm64 (read only) 2344188 2344380 192 0.0
.rodata 144364 144556 192 0.1
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2366580 2366796 216 0.0
.text 1329180 1329396 216 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1152967 1153235 268 0.0
rodata 145632 145884 252 0.2
text 793156 793176 20 0.0
p6 all-clusters-app default (read/write) 2511992 2512216 224 0.0
.text 1470256 1470480 224 0.0
light-app default (read/write) 2413168 2413360 192 0.0
.text 1371432 1371624 192 0.0
lock-app default (read/write) 2376848 2376976 128 0.0
.text 1335112 1335240 128 0.0
telink lighting-app tlsr9518adk80d (read/write) 798836 799084 248 0.0
text 567918 567948 30 0.0
Decreases (3 builds for cc13x2_26x2)
platform target config section 56f738f 198e21a change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read/write) 177204 177036 -168 -0.1
pump-app LP_CC2652R7 (read/write) 161064 160824 -240 -0.1
pump-controller-app LP_CC2652R7 (read/write) 176436 176204 -232 -0.1
Full report (19 builds for cc13x2_26x2, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 56f738f 198e21a change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 674307 674475 168 0.0
(read/write) 177204 177036 -168 -0.1
.bss 81552 81552 0 0.0
.data 3168 3168 0 0.0
.rodata 80579 80731 152 0.2
.text 593248 593264 16 0.0
lock-mtd LP_CC2652R7 (read only) 623443 623611 168 0.0
(read/write) 154304 154304 0 0.0
.bss 77280 77280 0 0.0
.data 3168 3168 0 0.0
.rodata 80467 80619 152 0.2
.text 542488 542504 16 0.0
pump-app LP_CC2652R7 (read only) 691607 691847 240 0.0
(read/write) 161064 160824 -240 -0.1
.bss 81944 81944 0 0.0
.data 3200 3200 0 0.0
.rodata 82511 82735 224 0.3
.text 608612 608628 16 0.0
pump-controller-app LP_CC2652R7 (read only) 675979 676211 232 0.0
(read/write) 176436 176204 -232 -0.1
.bss 81688 81688 0 0.0
.data 3164 3164 0 0.0
.rodata 79011 79227 216 0.3
.text 596484 596500 16 0.0
efr32 lighting-app BRD4161A (read only) 923476 923676 200 0.0
(read/write) 129580 129580 0 0.0
.bss 127584 127584 0 0.0
.data 1996 1996 0 0.0
.text 923468 923668 200 0.0
BRD4161A+rpc (read only) 951364 951564 200 0.0
(read/write) 145528 145528 0 0.0
.bss 143352 143352 0 0.0
.data 2176 2176 0 0.0
.text 951356 951556 200 0.0
window-app BRD4161A (read only) 860796 860980 184 0.0
(read/write) 127640 127640 0 0.0
.bss 125760 125760 0 0.0
.data 1880 1880 0 0.0
.text 860788 860972 184 0.0
esp32 all-clusters-app c3devkit (read only) 991668 991700 32 0.0
(read/write) 1461530 1461778 248 0.0
.dram0.bss 63000 63000 0 0.0
.dram0.data 14260 14268 8 0.1
.flash.rodata 198784 199032 248 0.1
.flash.text 991668 991700 32 0.0
.iram0.text 62572 62572 0 0.0
m5stack (read only) 1043503 1043527 24 0.0
(read/write) 462488 462744 256 0.1
.dram0.bss 68528 68528 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 227752 228008 256 0.1
.flash.text 1038119 1038143 24 0.0
.iram0.text 123415 123415 0 0.0
k32w light k32w061+release (read/write) 684828 685068 240 0.0
.bss 78240 78240 0 0.0
.data 1988 1988 0 0.0
.text 598800 599040 240 0.0
lock k32w061+release (read/write) 689668 689852 184 0.0
.bss 78816 78816 0 0.0
.data 1948 1948 0 0.0
.text 603104 603288 184 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 10278220 10278236 16 0.0
(read/write) 492033 492033 0 0.0
.bss 41041 41041 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 388704 388704 0 0.0
.dynamic 560 560 0 0.0
.got 57360 57360 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 512396 512412 16 0.0
.text 8663044 8663044 0 0.0
thermostat-no-ble arm64 (read only) 2344188 2344380 192 0.0
(read/write) 150257 150257 0 0.0
.bss 63169 63169 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 78184 78184 0 0.0
.dynamic 560 560 0 0.0
.got 4752 4752 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 144364 144556 192 0.1
.text 1972672 1972672 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2366580 2366796 216 0.0
.bss 185092 185092 0 0.0
.data 5792 5792 0 0.0
.text 1329180 1329396 216 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1152967 1153235 268 0.0
bss 135604 135604 0 0.0
rodata 145632 145884 252 0.2
text 793156 793176 20 0.0
p6 all-clusters-app default (read/write) 2511992 2512216 224 0.0
.bss 118528 118528 0 0.0
.data 2672 2672 0 0.0
.text 1470256 1470480 224 0.0
light-app default (read/write) 2413168 2413360 192 0.0
.bss 111992 111992 0 0.0
.data 2528 2528 0 0.0
.text 1371432 1371624 192 0.0
lock-app default (read/write) 2376848 2376976 128 0.0
.bss 111736 111736 0 0.0
.data 2488 2488 0 0.0
.text 1335112 1335240 128 0.0
telink lighting-app tlsr9518adk80d (read/write) 798836 799084 248 0.0
bss 70096 70096 0 0.0
noinit 40416 40416 0 0.0
text 567918 567948 30 0.0

@mlepage-google mlepage-google mentioned this pull request Apr 6, 2022
Merged
@mlepage-google mlepage-google mentioned this pull request Apr 6, 2022
Closed
@github-actions
Copy link

github-actions bot commented Apr 6, 2022 •
edited
Loading

PR #17115: Size comparison from ceefa88 to 3ef4d6a

Increases above 0.2%:

platform target config section ceefa88 3ef4d6a change % change
cc13x2_26x2 pump-app LP_CC2652R7 .rodata 82511 82735 224 0.3
pump-controller-app LP_CC2652R7 .rodata 79011 79227 216 0.3
Increases (19 builds for cc13x2_26x2, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section ceefa88 3ef4d6a change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 674307 674571 264 0.0
.rodata 80579 80731 152 0.2
.text 593248 593360 112 0.0
lock-mtd LP_CC2652R7 (read only) 623443 623707 264 0.0
.rodata 80467 80619 152 0.2
.text 542488 542600 112 0.0
pump-app LP_CC2652R7 (read only) 691607 691959 352 0.1
.rodata 82511 82735 224 0.3
.text 608612 608740 128 0.0
pump-controller-app LP_CC2652R7 (read only) 675979 676323 344 0.1
.rodata 79011 79227 216 0.3
.text 596484 596612 128 0.0
efr32 lighting-app BRD4161A (read only) 904532 904828 296 0.0
.text 904524 904820 296 0.0
BRD4161A+rpc (read only) 932420 932716 296 0.0
.text 932412 932708 296 0.0
window-app BRD4161A (read only) 841868 842148 280 0.0
.text 841860 842140 280 0.0
esp32 all-clusters-app c3devkit (read only) 991668 991834 166 0.0
(read/write) 1461530 1461778 248 0.0
.dram0.data 14260 14268 8 0.1
.flash.rodata 198784 199032 248 0.1
.flash.text 991668 991834 166 0.0
m5stack (read only) 1044367 1044467 100 0.0
(read/write) 462584 462840 256 0.1
.flash.rodata 227848 228104 256 0.1
.flash.text 1038983 1039083 100 0.0
k32w light k32w061+release (read/write) 684828 685180 352 0.1
.text 598800 599152 352 0.1
lock k32w061+release (read/write) 689668 689948 280 0.0
.text 603104 603384 280 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 10278220 10278236 16 0.0
.rodata 512396 512412 16 0.0
thermostat-no-ble arm64 (read only) 2344188 2344652 464 0.0
.rodata 144364 144556 192 0.1
.text 1972672 1972944 272 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2366580 2366860 280 0.0
.text 1329180 1329460 280 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1152967 1153347 380 0.0
rodata 145632 145884 252 0.2
text 793156 793276 120 0.0
p6 all-clusters-app default (read/write) 2511992 2512312 320 0.0
.text 1470256 1470576 320 0.0
light-app default (read/write) 2413168 2413456 288 0.0
.text 1371432 1371720 288 0.0
lock-app default (read/write) 2376848 2377072 224 0.0
.text 1335112 1335336 224 0.0
telink lighting-app tlsr9518adk80d (read/write) 798836 799244 408 0.1
text 567918 568106 188 0.0
Decreases (3 builds for cc13x2_26x2)
platform target config section ceefa88 3ef4d6a change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read/write) 177204 176940 -264 -0.1
pump-app LP_CC2652R7 (read/write) 161064 160712 -352 -0.2
pump-controller-app LP_CC2652R7 (read/write) 176436 176092 -344 -0.2
Full report (19 builds for cc13x2_26x2, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section ceefa88 3ef4d6a change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 674307 674571 264 0.0
(read/write) 177204 176940 -264 -0.1
.bss 81552 81552 0 0.0
.data 3168 3168 0 0.0
.rodata 80579 80731 152 0.2
.text 593248 593360 112 0.0
lock-mtd LP_CC2652R7 (read only) 623443 623707 264 0.0
(read/write) 154304 154304 0 0.0
.bss 77280 77280 0 0.0
.data 3168 3168 0 0.0
.rodata 80467 80619 152 0.2
.text 542488 542600 112 0.0
pump-app LP_CC2652R7 (read only) 691607 691959 352 0.1
(read/write) 161064 160712 -352 -0.2
.bss 81944 81944 0 0.0
.data 3200 3200 0 0.0
.rodata 82511 82735 224 0.3
.text 608612 608740 128 0.0
pump-controller-app LP_CC2652R7 (read only) 675979 676323 344 0.1
(read/write) 176436 176092 -344 -0.2
.bss 81688 81688 0 0.0
.data 3164 3164 0 0.0
.rodata 79011 79227 216 0.3
.text 596484 596612 128 0.0
efr32 lighting-app BRD4161A (read only) 904532 904828 296 0.0
(read/write) 133144 133144 0 0.0
.bss 131152 131152 0 0.0
.data 1992 1992 0 0.0
.text 904524 904820 296 0.0
BRD4161A+rpc (read only) 932420 932716 296 0.0
(read/write) 149092 149092 0 0.0
.bss 146920 146920 0 0.0
.data 2172 2172 0 0.0
.text 932412 932708 296 0.0
window-app BRD4161A (read only) 841868 842148 280 0.0
(read/write) 131204 131204 0 0.0
.bss 129328 129328 0 0.0
.data 1876 1876 0 0.0
.text 841860 842140 280 0.0
esp32 all-clusters-app c3devkit (read only) 991668 991834 166 0.0
(read/write) 1461530 1461778 248 0.0
.dram0.bss 63000 63000 0 0.0
.dram0.data 14260 14268 8 0.1
.flash.rodata 198784 199032 248 0.1
.flash.text 991668 991834 166 0.0
.iram0.text 62572 62572 0 0.0
m5stack (read only) 1044367 1044467 100 0.0
(read/write) 462584 462840 256 0.1
.dram0.bss 68528 68528 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 227848 228104 256 0.1
.flash.text 1038983 1039083 100 0.0
.iram0.text 123415 123415 0 0.0
k32w light k32w061+release (read/write) 684828 685180 352 0.1
.bss 78240 78240 0 0.0
.data 1988 1988 0 0.0
.text 598800 599152 352 0.1
lock k32w061+release (read/write) 689668 689948 280 0.0
.bss 78816 78816 0 0.0
.data 1948 1948 0 0.0
.text 603104 603384 280 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 10278220 10278236 16 0.0
(read/write) 492033 492033 0 0.0
.bss 41041 41041 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 388704 388704 0 0.0
.dynamic 560 560 0 0.0
.got 57360 57360 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 512396 512412 16 0.0
.text 8663044 8663044 0 0.0
thermostat-no-ble arm64 (read only) 2344188 2344652 464 0.0
(read/write) 150257 150257 0 0.0
.bss 63169 63169 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 78184 78184 0 0.0
.dynamic 560 560 0 0.0
.got 4752 4752 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 144364 144556 192 0.1
.text 1972672 1972944 272 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2366580 2366860 280 0.0
.bss 185092 185092 0 0.0
.data 5792 5792 0 0.0
.text 1329180 1329460 280 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1152967 1153347 380 0.0
bss 135604 135604 0 0.0
rodata 145632 145884 252 0.2
text 793156 793276 120 0.0
p6 all-clusters-app default (read/write) 2511992 2512312 320 0.0
.bss 118528 118528 0 0.0
.data 2672 2672 0 0.0
.text 1470256 1470576 320 0.0
light-app default (read/write) 2413168 2413456 288 0.0
.bss 111992 111992 0 0.0
.data 2528 2528 0 0.0
.text 1371432 1371720 288 0.0
lock-app default (read/write) 2376848 2377072 224 0.0
.bss 111736 111736 0 0.0
.data 2488 2488 0 0.0
.text 1335112 1335336 224 0.0
telink lighting-app tlsr9518adk80d (read/write) 798836 799244 408 0.1
bss 70096 70096 0 0.0
noinit 40416 40416 0 0.0
text 567918 568106 188 0.0

@restyled-io restyled-io bot mentioned this pull request Apr 7, 2022
Closed
@github-actions
Copy link

github-actions bot commented Apr 7, 2022 •
edited
Loading

PR #17115: Size comparison from d56fca1 to da2cb69

Increases above 0.2%:

platform target config section d56fca1 da2cb69 change % change
cc13x2_26x2 pump-app LP_CC2652R7 .rodata 75243 75467 224 0.3
pump-controller-app LP_CC2652R7 .rodata 79027 79243 216 0.3
Increases (28 builds for cc13x2_26x2, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section d56fca1 da2cb69 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 674515 674683 168 0.0
.rodata 80563 80715 152 0.2
.text 593472 593488 16 0.0
lock-mtd LP_CC2652R7 (read only) 623651 623819 168 0.0
.rodata 80451 80603 152 0.2
.text 542712 542728 16 0.0
pump-app LP_CC2652R7 (read only) 681875 682115 240 0.0
.rodata 75243 75467 224 0.3
.text 606148 606164 16 0.0
pump-controller-app LP_CC2652R7 (read only) 676219 676451 232 0.0
.rodata 79027 79243 216 0.3
.text 596708 596724 16 0.0
efr32 lighting-app BRD4161A (read only) 904908 905100 192 0.0
.text 904900 905092 192 0.0
BRD4161A+rpc (read only) 932780 932972 192 0.0
.text 932772 932964 192 0.0
window-app BRD4161A (read only) 842196 842380 184 0.0
.text 842188 842372 184 0.0
esp32 all-clusters-app c3devkit (read only) 991900 991932 32 0.0
(read/write) 1461762 1462042 280 0.0
.dram0.data 14356 14364 8 0.1
.flash.rodata 198984 199264 280 0.1
.flash.text 991900 991932 32 0.0
m5stack (read only) 1044615 1044639 24 0.0
(read/write) 462816 463104 288 0.1
.flash.rodata 228048 228336 288 0.1
.flash.text 1039231 1039255 24 0.0
k32w light k32w061+release (read/write) 685148 685388 240 0.0
.text 599104 599344 240 0.0
lock k32w061+release (read/write) 689932 690100 168 0.0
.text 603352 603520 168 0.0
linux all-clusters-app debug (read only) 2622689 2622945 256 0.0
.rodata 222405 222661 256 0.1
bridge-app debug+rpc (read only) 1831421 1831645 224 0.0
.rodata 148281 148505 224 0.2
chip-tool debug .rodata 538389 538421 32 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 10281420 10281436 16 0.0
.rodata 512540 512556 16 0.0
door-lock-app debug (read only) 2102513 2102737 224 0.0
.rodata 186313 186537 224 0.1
lighting-app debug+rpc (read only) 2305017 2305177 160 0.0
.rodata 181513 181673 160 0.1
ota-provider-app debug (read only) 2040353 2040481 128 0.0
.rodata 172323 172451 128 0.1
ota-requestor-app debug (read only) 2069657 2069817 160 0.0
.rodata 168716 168876 160 0.1
shell debug (read only) 2517473 2517761 288 0.0
.rodata 214002 214290 288 0.1
thermostat-no-ble arm64 (read only) 2348476 2348700 224 0.0
.rodata 144428 144652 224 0.2
tv-app debug (read only) 2794369 2794529 160 0.0
.rodata 213323 213483 160 0.1
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2366844 2366996 152 0.0
.text 1329444 1329596 152 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1153375 1153679 304 0.0
rodata 145832 146120 288 0.2
text 793388 793408 20 0.0
p6 all-clusters-app default (read/write) 2512552 2512808 256 0.0
.text 1470816 1471072 256 0.0
light-app default (read/write) 2413576 2413776 200 0.0
.text 1371840 1372040 200 0.0
lock-app default (read/write) 2377208 2377336 128 0.0
.text 1335472 1335600 128 0.0
telink lighting-app tlsr9518adk80d (read/write) 799240 799496 256 0.0
text 568274 568306 32 0.0
Decreases (4 builds for cc13x2_26x2, linux)
platform target config section d56fca1 da2cb69 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read/write) 176964 176796 -168 -0.1
pump-app LP_CC2652R7 (read/write) 170780 170540 -240 -0.1
pump-controller-app LP_CC2652R7 (read/write) 176164 175932 -232 -0.1
linux chip-tool debug (read only) 10680053 10679989 -64 -0.0
.text 9312725 9312629 -96 -0.0
Full report (28 builds for cc13x2_26x2, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section d56fca1 da2cb69 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 674515 674683 168 0.0
(read/write) 176964 176796 -168 -0.1
.bss 81520 81520 0 0.0
.data 3216 3216 0 0.0
.rodata 80563 80715 152 0.2
.text 593472 593488 16 0.0
lock-mtd LP_CC2652R7 (read only) 623651 623819 168 0.0
(read/write) 154320 154320 0 0.0
.bss 77248 77248 0 0.0
.data 3216 3216 0 0.0
.rodata 80451 80603 152 0.2
.text 542712 542728 16 0.0
pump-app LP_CC2652R7 (read only) 681875 682115 240 0.0
(read/write) 170780 170540 -240 -0.1
.bss 81928 81928 0 0.0
.data 3248 3248 0 0.0
.rodata 75243 75467 224 0.3
.text 606148 606164 16 0.0
pump-controller-app LP_CC2652R7 (read only) 676219 676451 232 0.0
(read/write) 176164 175932 -232 -0.1
.bss 81656 81656 0 0.0
.data 3212 3212 0 0.0
.rodata 79027 79243 216 0.3
.text 596708 596724 16 0.0
efr32 lighting-app BRD4161A (read only) 904908 905100 192 0.0
(read/write) 133160 133160 0 0.0
.bss 131120 131120 0 0.0
.data 2040 2040 0 0.0
.text 904900 905092 192 0.0
BRD4161A+rpc (read only) 932780 932972 192 0.0
(read/write) 149108 149108 0 0.0
.bss 146888 146888 0 0.0
.data 2220 2220 0 0.0
.text 932772 932964 192 0.0
window-app BRD4161A (read only) 842196 842380 184 0.0
(read/write) 131228 131228 0 0.0
.bss 129280 129280 0 0.0
.data 1948 1948 0 0.0
.text 842188 842372 184 0.0
esp32 all-clusters-app c3devkit (read only) 991900 991932 32 0.0
(read/write) 1461762 1462042 280 0.0
.dram0.bss 62936 62936 0 0.0
.dram0.data 14356 14364 8 0.1
.flash.rodata 198984 199264 280 0.1
.flash.text 991900 991932 32 0.0
.iram0.text 62572 62572 0 0.0
m5stack (read only) 1044615 1044639 24 0.0
(read/write) 462816 463104 288 0.1
.dram0.bss 68464 68464 0 0.0
.dram0.data 34160 34160 0 0.0
.flash.rodata 228048 228336 288 0.1
.flash.text 1039231 1039255 24 0.0
.iram0.text 123415 123415 0 0.0
k32w light k32w061+release (read/write) 685148 685388 240 0.0
.bss 78208 78208 0 0.0
.data 2036 2036 0 0.0
.text 599104 599344 240 0.0
lock k32w061+release (read/write) 689932 690100 168 0.0
.bss 78784 78784 0 0.0
.data 1996 1996 0 0.0
.text 603352 603520 168 0.0
linux all-clusters-app debug (read only) 2622689 2622945 256 0.0
(read/write) 145640 145640 0 0.0
.bss 57664 57664 0 0.0
.data 1824 1824 0 0.0
.data.rel.ro 80264 80264 0 0.0
.dynamic 592 592 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 222405 222661 256 0.1
.text 2231410 2231410 0 0.0
bridge-app debug+rpc (read only) 1831421 1831645 224 0.0
(read/write) 91304 91304 0 0.0
.bss 44344 44344 0 0.0
.data 2912 2912 0 0.0
.data.rel.ro 38936 38936 0 0.0
.dynamic 592 592 0 0.0
.got 3936 3936 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 148281 148505 224 0.2
.text 1565669 1565669 0 0.0
chip-tool debug (read only) 10680053 10679989 -64 -0.0
(read/write) 371736 371736 0 0.0
.bss 22752 22752 0 0.0
.data 1104 1104 0 0.0
.data.rel.ro 341632 341632 0 0.0
.dynamic 624 624 0 0.0
.got 4928 4928 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 538389 538421 32 0.0
.text 9312725 9312629 -96 -0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 10281420 10281436 16 0.0
(read/write) 492177 492177 0 0.0
.bss 41009 41009 0 0.0
.data 1168 1168 0 0.0
.data.rel.ro 388800 388800 0 0.0
.dynamic 560 560 0 0.0
.got 57392 57392 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 512540 512556 16 0.0
.text 8665812 8665812 0 0.0
door-lock-app debug (read only) 2102513 2102737 224 0.0
(read/write) 119024 119024 0 0.0
.bss 47936 47936 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 64056 64056 0 0.0
.dynamic 592 592 0 0.0
.got 4264 4264 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 186313 186537 224 0.1
.text 1761554 1761554 0 0.0
lighting-app debug+rpc (read only) 2305017 2305177 160 0.0
(read/write) 127344 127344 0 0.0
.bss 50144 50144 0 0.0
.data 1952 1952 0 0.0
.data.rel.ro 69544 69544 0 0.0
.dynamic 608 608 0 0.0
.got 4312 4312 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 181513 181673 160 0.1
.text 1958770 1958770 0 0.0
ota-provider-app debug (read only) 2040353 2040481 128 0.0
(read/write) 114592 114592 0 0.0
.bss 47840 47840 0 0.0
.data 1608 1608 0 0.0
.data.rel.ro 59384 59384 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 172323 172451 128 0.1
.text 1712466 1712466 0 0.0
ota-requestor-app debug (read only) 2069657 2069817 160 0.0
(read/write) 117880 117880 0 0.0
.bss 48800 48800 0 0.0
.data 1864 1864 0 0.0
.data.rel.ro 61624 61624 0 0.0
.dynamic 592 592 0 0.0
.got 4304 4304 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 168716 168876 160 0.1
.text 1743602 1743602 0 0.0
shell debug (read only) 2517473 2517761 288 0.0
(read/write) 149168 149168 0 0.0
.bss 67368 67368 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 74808 74808 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 214002 214290 288 0.1
.text 2144082 2144082 0 0.0
thermostat-no-ble arm64 (read only) 2348476 2348700 224 0.0
(read/write) 150497 150497 0 0.0
.bss 63025 63025 0 0.0
.data 1424 1424 0 0.0
.data.rel.ro 78264 78264 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 144428 144652 224 0.2
.text 1976576 1976576 0 0.0
tv-app debug (read only) 2794369 2794529 160 0.0
(read/write) 251096 251096 0 0.0
.bss 165032 165032 0 0.0
.data 4448 4448 0 0.0
.data.rel.ro 75408 75408 0 0.0
.dynamic 592 592 0 0.0
.got 4680 4680 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 213323 213483 160 0.1
.text 2401330 2401330 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2366844 2366996 152 0.0
.bss 185060 185060 0 0.0
.data 5840 5840 0 0.0
.text 1329444 1329596 152 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1153375 1153679 304 0.0
bss 135540 135540 0 0.0
rodata 145832 146120 288 0.2
text 793388 793408 20 0.0
p6 all-clusters-app default (read/write) 2512552 2512808 256 0.0
.bss 118464 118464 0 0.0
.data 2768 2768 0 0.0
.text 1470816 1471072 256 0.0
light-app default (read/write) 2413576 2413776 200 0.0
.bss 111960 111960 0 0.0
.data 2576 2576 0 0.0
.text 1371840 1372040 200 0.0
lock-app default (read/write) 2377208 2377336 128 0.0
.bss 111704 111704 0 0.0
.data 2536 2536 0 0.0
.text 1335472 1335600 128 0.0
telink lighting-app tlsr9518adk80d (read/write) 799240 799496 256 0.0
bss 70064 70064 0 0.0
noinit 40416 40416 0 0.0
text 568274 568306 32 0.0

@tlykkeberg-grundfos tlykkeberg-grundfos mentioned this pull request Apr 7, 2022
Merged
@mlepage-google mlepage-google merged commit f9139f2 into project-chip:master Apr 7, 2022
@mlepage-google mlepage-google deleted the update-clusters-access branch April 7, 2022 19:29
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this pull request Apr 14, 2022
@mlepage-google @andrei-menzopol
Update more cluster access privileges (project-chip#17115)
6abfcbc 
Also fix thermostat cluster attribute name
(should be "ac compressor type" not "ac compressor" per spec)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
app controller review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mlepage-google @tcarmelveilleux @bzbarsky-apple