Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Glob blacklist the interactive chip-tool build when cross-compiling #17084

Merged
merged 8 commits into from
Apr 5, 2022
Merged

Glob blacklist the interactive chip-tool build when cross-compiling #17084

merged 8 commits into from
Apr 5, 2022

Conversation

andy31415
Copy link
Contributor

Problem

libreadline is not available in the cross compile sysroot, so after #16135 cross-compiles fail with:

2022-04-02 13:13:25 INFO    FAILED: obj/commands/interactive/chip-tool-utils.InteractiveCommands.cpp.o 
2022-04-02 13:13:25 INFO    clang++ -MMD -MF obj/commands/interactive/chip-tool-utils.InteractiveCommands.cpp.o.d --target=aarch64-linux-gnu -O0 -g2 -fno-common -ffunction-sections -fdata-sections -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -fPIC -Wall -Werror -Wextra -Wshadow -Wunreachable-code -Wvla -Wformat -Wformat-nonliteral -Wformat-security -Wimplicit-fallthrough …-tool/third_party/connectedhomeip/third_party/jsoncpp/repo/include -I../../examples/chip-tool/third_party/connectedhomeip/examples/common/tracing -c ../../examples/chip-tool/commands/interactive/InteractiveCommands.cpp -o obj/commands/interactive/chip-tool-utils.InteractiveCommands.cpp.o
2022-04-02 13:13:25 INFO    ../../examples/chip-tool/commands/interactive/InteractiveCommands.cpp:21:10: fatal error: 'readline/history.h' file not found
2022-04-02 13:13:25 INFO    #include <readline/history.h>

Change overview

Blacklist the interactive build when cross compiling, only the non-interactive builds will be compiled.

Testing

Checked that glob takes effect. CI files were updated.

@boring-cyborg boring-cyborg bot added the scripts label Apr 5, 2022
@andy31415 andy31415 added the hotfix urgent fix needed, can bypass review label Apr 5, 2022
@pullapprove pullapprove bot added review - pending and removed hotfix urgent fix needed, can bypass review scripts labels Apr 5, 2022
@andy31415
Copy link
Contributor Author

Hotfix: this blocks cloudbuild

@pullapprove pullapprove bot added the scripts label Apr 5, 2022
@andy31415
Copy link
Contributor Author

Need to revisit this a bit: it looks like blacklisting is applying to non-arm builds as well...

@andy31415 andy31415 added the hotfix urgent fix needed, can bypass review label Apr 5, 2022
@andy31415
Copy link
Contributor Author

Updated:

  • no-interactive is always whitelisted
  • explicit blacklist for arm64 cross compile of interactive chip-tool

@github-actions
Copy link

github-actions bot commented Apr 5, 2022 •
edited
Loading

PR #17084: Size comparison from 8089bdd to 6e4762e

Full report (28 builds for cc13x2_26x2, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 8089bdd 6e4762e change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 670727 670727 0 0.0
(read/write) 180736 180736 0 0.0
.bss 81504 81504 0 0.0
.data 3164 3164 0 0.0
.rodata 80039 80039 0 0.0
.text 590208 590208 0 0.0
lock-mtd LP_CC2652R7 (read only) 619855 619855 0 0.0
(read/write) 154252 154252 0 0.0
.bss 77232 77232 0 0.0
.data 3164 3164 0 0.0
.rodata 79927 79927 0 0.0
.text 539440 539440 0 0.0
pump-app LP_CC2652R7 (read only) 690143 690143 0 0.0
(read/write) 162496 162496 0 0.0
.bss 81912 81912 0 0.0
.data 3196 3196 0 0.0
.rodata 82127 82127 0 0.0
.text 607532 607532 0 0.0
pump-controller-app LP_CC2652R7 (read only) 672391 672391 0 0.0
(read/write) 179976 179976 0 0.0
.bss 81640 81640 0 0.0
.data 3160 3160 0 0.0
.rodata 78463 78463 0 0.0
.text 593444 593444 0 0.0
efr32 lighting-app BRD4161A (read only) 919420 919420 0 0.0
(read/write) 129536 129536 0 0.0
.bss 127544 127544 0 0.0
.data 1992 1992 0 0.0
.text 919412 919412 0 0.0
BRD4161A+rpc (read only) 947332 947332 0 0.0
(read/write) 145484 145484 0 0.0
.bss 143312 143312 0 0.0
.data 2172 2172 0 0.0
.text 947324 947324 0 0.0
window-app BRD4161A (read only) 854588 854588 0 0.0
(read/write) 127560 127560 0 0.0
.bss 125688 125688 0 0.0
.data 1872 1872 0 0.0
.text 854580 854580 0 0.0
esp32 all-clusters-app c3devkit (read only) 988372 988372 0 0.0
(read/write) 1460922 1460922 0 0.0
.dram0.bss 62952 62952 0 0.0
.dram0.data 14196 14196 0 0.0
.flash.rodata 198288 198288 0 0.0
.flash.text 988372 988372 0 0.0
.iram0.text 62572 62572 0 0.0
m5stack (read only) 1040751 1040751 0 0.0
(read/write) 461912 461912 0 0.0
.dram0.bss 68480 68480 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 227232 227232 0 0.0
.flash.text 1035367 1035367 0 0.0
.iram0.text 123415 123415 0 0.0
k32w light k32w061+release (read/write) 681576 681576 0 0.0
.bss 78192 78192 0 0.0
.data 1984 1984 0 0.0
.text 595600 595600 0 0.0
lock k32w061+release (read/write) 686056 686056 0 0.0
.bss 78776 78776 0 0.0
.data 1944 1944 0 0.0
.text 599536 599536 0 0.0
linux all-clusters-app debug (read only) 2595177 2595177 0 0.0
(read/write) 145000 145000 0 0.0
.bss 57664 57664 0 0.0
.data 1440 1440 0 0.0
.data.rel.ro 80008 80008 0 0.0
.dynamic 592 592 0 0.0
.got 4312 4312 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 220965 220965 0 0.0
.text 2205954 2205954 0 0.0
bridge-app debug+rpc (read only) 1803973 1803973 0 0.0
(read/write) 90424 90424 0 0.0
.bss 44584 44584 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 38712 38712 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 147225 147225 0 0.0
.text 1539877 1539877 0 0.0
chip-tool debug (read only) 10633141 10633141 0 0.0
(read/write) 370648 370648 0 0.0
.bss 22592 22592 0 0.0
.data 1040 1040 0 0.0
.data.rel.ro 340784 340784 0 0.0
.dynamic 624 624 0 0.0
.got 4928 4928 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 535789 535789 0 0.0
.text 9270309 9270309 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 10243708 10243708 0 0.0
(read/write) 490769 490769 0 0.0
.bss 40897 40897 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 387792 387792 0 0.0
.dynamic 560 560 0 0.0
.got 57144 57144 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 510460 510460 0 0.0
.text 8633156 8633156 0 0.0
door-lock-app debug (read only) 2075489 2075489 0 0.0
(read/write) 118448 118448 0 0.0
.bss 47904 47904 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 63832 63832 0 0.0
.dynamic 592 592 0 0.0
.got 4256 4256 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 185257 185257 0 0.0
.text 1736178 1736178 0 0.0
lighting-app debug+rpc (read only) 2254969 2254969 0 0.0
(read/write) 125440 125440 0 0.0
.bss 49216 49216 0 0.0
.data 1600 1600 0 0.0
.data.rel.ro 68936 68936 0 0.0
.dynamic 608 608 0 0.0
.got 4304 4304 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 179337 179337 0 0.0
.text 1912114 1912114 0 0.0
ota-provider-app debug (read only) 2013329 2013329 0 0.0
(read/write) 114016 114016 0 0.0
.bss 47744 47744 0 0.0
.data 1384 1384 0 0.0
.data.rel.ro 59160 59160 0 0.0
.dynamic 608 608 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 171067 171067 0 0.0
.text 1687298 1687298 0 0.0
ota-requestor-app debug (read only) 2042969 2042969 0 0.0
(read/write) 117336 117336 0 0.0
.bss 48736 48736 0 0.0
.data 1608 1608 0 0.0
.data.rel.ro 61400 61400 0 0.0
.dynamic 592 592 0 0.0
.got 4296 4296 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 167620 167620 0 0.0
.text 1718610 1718610 0 0.0
shell debug (read only) 2490889 2490889 0 0.0
(read/write) 148464 148464 0 0.0
.bss 67336 67336 0 0.0
.data 848 848 0 0.0
.data.rel.ro 74552 74552 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 212658 212658 0 0.0
.text 2119458 2119458 0 0.0
thermostat-no-ble arm64 (read only) 2327212 2327212 0 0.0
(read/write) 149681 149681 0 0.0
.bss 62977 62977 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 77904 77904 0 0.0
.dynamic 560 560 0 0.0
.got 4648 4648 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 143388 143388 0 0.0
.text 1957648 1957648 0 0.0
tv-app debug (read only) 2764393 2764393 0 0.0
(read/write) 250112 250112 0 0.0
.bss 165360 165360 0 0.0
.data 3392 3392 0 0.0
.data.rel.ro 75168 75168 0 0.0
.dynamic 592 592 0 0.0
.got 4672 4672 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 211211 211211 0 0.0
.text 2374114 2374114 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2363020 2363020 0 0.0
.bss 185052 185052 0 0.0
.data 5784 5784 0 0.0
.text 1325620 1325620 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1149431 1149431 0 0.0
bss 135556 135556 0 0.0
rodata 145088 145088 0 0.0
text 790160 790160 0 0.0
p6 all-clusters-app default (read/write) 2507784 2507784 0 0.0
.bss 118480 118480 0 0.0
.data 2672 2672 0 0.0
.text 1466048 1466048 0 0.0
light-app default (read/write) 2408960 2408960 0 0.0
.bss 111944 111944 0 0.0
.data 2528 2528 0 0.0
.text 1367224 1367224 0 0.0
lock-app default (read/write) 2372672 2372672 0 0.0
.bss 111688 111688 0 0.0
.data 2488 2488 0 0.0
.text 1330936 1330936 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 794824 794824 0 0.0
bss 70044 70044 0 0.0
noinit 40416 40416 0 0.0
text 564548 564548 0 0.0

@andy31415 andy31415 mentioned this pull request Apr 5, 2022
Closed
@andy31415 andy31415 merged commit ca6f377 into project-chip:master Apr 5, 2022
chencheung pushed a commit to chencheung/connectedhomeip that referenced this pull request Apr 6, 2022
@andy31415 @chencheung
Glob blacklist the interactive chip-tool build when cross-compiling (p…
1f33ea9 
…roject-chip#17084)

* Glob blacklist interactive builds of chip-tool in cross compile

* Fix unit tests

* blacklist only arm64 builds not all builds

* Only blacklist chip tool

* Update tests

* Whitelist chip tool nointeractive builds

* Fix unit tests
chencheung pushed a commit to chencheung/connectedhomeip that referenced this pull request Apr 6, 2022
@andy31415 @chencheung
Glob blacklist the interactive chip-tool build when cross-compiling (p…
fb1e583 
…roject-chip#17084)

* Glob blacklist interactive builds of chip-tool in cross compile

* Fix unit tests

* blacklist only arm64 builds not all builds

* Only blacklist chip tool

* Update tests

* Whitelist chip tool nointeractive builds

* Fix unit tests
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this pull request Apr 14, 2022
@andy31415 @andrei-menzopol
Glob blacklist the interactive chip-tool build when cross-compiling (p…
711c6a4 
…roject-chip#17084)

* Glob blacklist interactive builds of chip-tool in cross compile

* Fix unit tests

* blacklist only arm64 builds not all builds

* Only blacklist chip tool

* Update tests

* Whitelist chip tool nointeractive builds

* Fix unit tests
mspang pushed a commit that referenced this pull request Apr 21, 2022
@andy31415 @mspang
Glob blacklist the interactive chip-tool build when cross-compiling (#…
08d5bed 
…17084)

* Glob blacklist interactive builds of chip-tool in cross compile

* Fix unit tests

* blacklist only arm64 builds not all builds

* Only blacklist chip tool

* Update tests

* Whitelist chip tool nointeractive builds

* Fix unit tests

(cherry picked from commit ca6f377)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
hotfix urgent fix needed, can bypass review review - pending scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@andy31415