Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chip tool interactive #16135

Merged
merged 3 commits into from
Mar 30, 2022
Merged

Chip tool interactive #16135

merged 3 commits into from
Mar 30, 2022

Conversation

vivien-apple
Copy link
Contributor

Problem

chip-tool does not allow to set up multiple subscriptions.

It uses readline under the hood which maps to libedit on Mac.

Change overview

  • Add a new interactive mode to chip-tool that can be started using chip-tool interactive start and it can be cleanly exited by typing quit()
  • Clean up the vector arguments to let the commands be reusable
  • Add subscriptions shutdown-subscription and subscritions shutdown-subscriptions commands to chip-tool
  • Remove the wait argument of subscribe attributes since this is now replaced by the interactive

Testing

I have done various tests locally to check that it works without breaking the current behaviour.

@vivien-apple vivien-apple self-assigned this Mar 11, 2022
@vivien-apple vivien-apple mentioned this pull request Mar 24, 2022
Closed
woody-apple
woody-apple approved these changes Mar 26, 2022
View reviewed changes
Copy link
Contributor

@woody-apple woody-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fast tracking given this has had > 3 days for review.

@woody-apple
Copy link
Contributor

/rebase

@vivien-apple vivien-apple force-pushed the ChipTool_Interactive branch from 1e0a796 to 729e520 Compare March 28, 2022 15:48
@github-actions
Copy link

github-actions bot commented Mar 28, 2022 •
edited
Loading

PR #16135: Size comparison from 125e73c to 729e520

Increases above 0.2%:

platform target config section 125e73c 729e520 change % change
linux chip-tool debug .bss 22464 22528 64 0.3
.dynamic 608 624 16 2.6
.got 4824 4872 48 1.0
.init_array 640 648 8 1.2
Increases (1 build for linux)
platform target config section 125e73c 729e520 change % change
linux chip-tool debug (read only) 10183973 10189693 5720 0.1
(read/write) 355656 355984 328 0.1
.bss 22464 22528 64 0.3
.data.rel.ro 326008 326200 192 0.1
.dynamic 608 624 16 2.6
.got 4824 4872 48 1.0
.init_array 640 648 8 1.2
.rodata 518805 519253 448 0.1
.text 8880629 8884853 4224 0.0
Full report (25 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 125e73c 729e520 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 605426 605426 0 0.0
.app_xip_area 512356 512356 0 0.0
.bss 75816 75816 0 0.0
.data 604 604 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 563238 563238 0 0.0
.app_xip_area 471696 471696 0 0.0
.bss 74320 74320 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 575498 575498 0 0.0
.app_xip_area 474308 474308 0 0.0
.bss 83648 83648 0 0.0
.data 508 508 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 926600 926600 0 0.0
(read/write) 128952 128952 0 0.0
.bss 126952 126952 0 0.0
.data 1996 1996 0 0.0
.text 926592 926592 0 0.0
BRD4161A+rpc (read only) 955416 955416 0 0.0
(read/write) 144904 144904 0 0.0
.bss 142728 142728 0 0.0
.data 2176 2176 0 0.0
.text 955408 955408 0 0.0
window-app BRD4161A (read only) 856004 856004 0 0.0
(read/write) 126912 126912 0 0.0
.bss 125040 125040 0 0.0
.data 1872 1872 0 0.0
.text 855996 855996 0 0.0
esp32 all-clusters-app c3devkit (read only) 966714 966714 0 0.0
(read/write) 1394810 1394810 0 0.0
.dram0.bss 62240 62240 0 0.0
.dram0.data 14204 14204 0 0.0
.flash.rodata 199456 199456 0 0.0
.flash.text 966714 966714 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1023131 1023131 0 0.0
(read/write) 462572 462572 0 0.0
.dram0.bss 67768 67768 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 228944 228944 0 0.0
.flash.text 1017747 1017747 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 704272 704272 0 0.0
.bss 77808 77808 0 0.0
.data 1876 1876 0 0.0
.text 618788 618788 0 0.0
lock k32w061+release (read/write) 703364 703364 0 0.0
.bss 77784 77784 0 0.0
.data 1916 1916 0 0.0
.text 617864 617864 0 0.0
linux all-clusters-app debug (read only) 2525993 2525993 0 0.0
(read/write) 143352 143352 0 0.0
.bss 57408 57408 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 78920 78920 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 944 944 0 0.0
.rodata 216549 216549 0 0.0
.text 2145618 2145618 0 0.0
bridge-app debug+rpc (read only) 1765325 1765325 0 0.0
(read/write) 89520 89520 0 0.0
.bss 44520 44520 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 37936 37936 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 144684 144684 0 0.0
.text 1505285 1505285 0 0.0
chip-tool debug (read only) 10183973 10189693 5720 0.1
(read/write) 355656 355984 328 0.1
.bss 22464 22528 64 0.3
.data 1072 1072 0 0.0
.data.rel.ro 326008 326200 192 0.1
.dynamic 608 624 16 2.6
.got 4824 4872 48 1.0
.init 27 27 0 0.0
.init_array 640 648 8 1.2
.rodata 518805 519253 448 0.1
.text 8880629 8884853 4224 0.0
door-lock-app debug (read only) 2017153 2017153 0 0.0
(read/write) 116896 116896 0 0.0
.bss 47648 47648 0 0.0
.data 992 992 0 0.0
.data.rel.ro 62840 62840 0 0.0
.dynamic 592 592 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 181276 181276 0 0.0
.text 1686066 1686066 0 0.0
lighting-app debug+rpc (read only) 2191489 2191489 0 0.0
(read/write) 123888 123888 0 0.0
.bss 48928 48928 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 67928 67928 0 0.0
.dynamic 608 608 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 175356 175356 0 0.0
.text 1856962 1856962 0 0.0
ota-provider-app debug (read only) 1957977 1957977 0 0.0
(read/write) 112688 112688 0 0.0
.bss 47584 47584 0 0.0
.data 1256 1256 0 0.0
.data.rel.ro 58184 58184 0 0.0
.dynamic 608 608 0 0.0
.got 4384 4384 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 167115 167115 0 0.0
.text 1638994 1638994 0 0.0
ota-requestor-app debug (read only) 1985569 1985569 0 0.0
(read/write) 115912 115912 0 0.0
.bss 48512 48512 0 0.0
.data 1480 1480 0 0.0
.data.rel.ro 60440 60440 0 0.0
.dynamic 592 592 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 163236 163236 0 0.0
.text 1669458 1669458 0 0.0
shell debug (read only) 2441625 2441625 0 0.0
(read/write) 147368 147368 0 0.0
.bss 67304 67304 0 0.0
.data 800 800 0 0.0
.data.rel.ro 73568 73568 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 210034 210034 0 0.0
.text 2074642 2074642 0 0.0
tv-app debug (read only) 2688417 2688417 0 0.0
(read/write) 247520 247520 0 0.0
.bss 164288 164288 0 0.0
.data 3136 3136 0 0.0
.data.rel.ro 74048 74048 0 0.0
.dynamic 592 592 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 206059 206059 0 0.0
.text 2307730 2307730 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2355644 2355644 0 0.0
.bss 184860 184860 0 0.0
.data 5760 5760 0 0.0
.text 1318244 1318244 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1143379 1143379 0 0.0
bss 142892 142892 0 0.0
rodata 142364 142364 0 0.0
text 783240 783240 0 0.0
p6 all-clusters-app default (read/write) 2498384 2498384 0 0.0
.bss 118280 118280 0 0.0
.data 2640 2640 0 0.0
.text 1456648 1456648 0 0.0
light-app default (read/write) 2400816 2400816 0 0.0
.bss 111752 111752 0 0.0
.data 2496 2496 0 0.0
.text 1359080 1359080 0 0.0
lock-app default (read/write) 2364352 2364352 0 0.0
.bss 111496 111496 0 0.0
.data 2456 2456 0 0.0
.text 1322616 1322616 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 898750 898750 0 0.0
bss 87596 87596 0 0.0
noinit 37160 37160 0 0.0
text 635626 635626 0 0.0

@vivien-apple vivien-apple force-pushed the ChipTool_Interactive branch from 729e520 to d10d10d Compare March 30, 2022 07:41
@vivien-apple vivien-apple force-pushed the ChipTool_Interactive branch 2 times, most recently from b207340 to 6e98f2c Compare March 30, 2022 08:07
@github-actions
Copy link

github-actions bot commented Mar 30, 2022 •
edited
Loading

PR #16135: Size comparison from 08906fb to 6e98f2c

Increases above 0.2%:

platform target config section 08906fb 6e98f2c change % change
linux chip-tool debug .bss 22464 22528 64 0.3
.dynamic 608 624 16 2.6
.got 4824 4872 48 1.0
.init_array 640 648 8 1.2
Increases (1 build for linux)
platform target config section 08906fb 6e98f2c change % change
linux chip-tool debug (read only) 10311229 10316917 5688 0.1
(read/write) 356456 356784 328 0.1
.bss 22464 22528 64 0.3
.data.rel.ro 326808 327000 192 0.1
.dynamic 608 624 16 2.6
.got 4824 4872 48 1.0
.init_array 640 648 8 1.2
.rodata 525877 526293 416 0.1
.text 8999013 9003237 4224 0.0
Full report (25 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 08906fb 6e98f2c change % change
cyw30739 light cyw930739m2evb_01 (read/write) 606810 606810 0 0.0
.app_xip_area 513580 513580 0 0.0
.bss 75976 75976 0 0.0
.data 604 604 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 564358 564358 0 0.0
.app_xip_area 472656 472656 0 0.0
.bss 74480 74480 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 576538 576538 0 0.0
.app_xip_area 475188 475188 0 0.0
.bss 83808 83808 0 0.0
.data 508 508 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 927928 927928 0 0.0
(read/write) 129112 129112 0 0.0
.bss 127112 127112 0 0.0
.data 1996 1996 0 0.0
.text 927920 927920 0 0.0
BRD4161A+rpc (read only) 956920 956920 0 0.0
(read/write) 145064 145064 0 0.0
.bss 142888 142888 0 0.0
.data 2176 2176 0 0.0
.text 956912 956912 0 0.0
window-app BRD4161A (read only) 857412 857412 0 0.0
(read/write) 127072 127072 0 0.0
.bss 125200 125200 0 0.0
.data 1872 1872 0 0.0
.text 857404 857404 0 0.0
esp32 all-clusters-app c3devkit (read only) 968374 968374 0 0.0
(read/write) 1394770 1394770 0 0.0
.dram0.bss 62416 62416 0 0.0
.dram0.data 14204 14204 0 0.0
.flash.rodata 199240 199240 0 0.0
.flash.text 968374 968374 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1024075 1024075 0 0.0
(read/write) 462532 462532 0 0.0
.dram0.bss 67944 67944 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 228728 228728 0 0.0
.flash.text 1018691 1018691 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 705392 705392 0 0.0
.bss 77968 77968 0 0.0
.data 1876 1876 0 0.0
.text 619748 619748 0 0.0
lock k32w061+release (read/write) 704508 704508 0 0.0
.bss 77944 77944 0 0.0
.data 1916 1916 0 0.0
.text 618848 618848 0 0.0
linux all-clusters-app debug (read only) 2536721 2536721 0 0.0
(read/write) 143384 143384 0 0.0
.bss 57408 57408 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 78952 78952 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 944 944 0 0.0
.rodata 216613 216613 0 0.0
.text 2156210 2156210 0 0.0
bridge-app debug+rpc (read only) 1770437 1770437 0 0.0
(read/write) 89552 89552 0 0.0
.bss 44520 44520 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 37968 37968 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 145004 145004 0 0.0
.text 1510005 1510005 0 0.0
chip-tool debug (read only) 10311229 10316917 5688 0.1
(read/write) 356456 356784 328 0.1
.bss 22464 22528 64 0.3
.data 1072 1072 0 0.0
.data.rel.ro 326808 327000 192 0.1
.dynamic 608 624 16 2.6
.got 4824 4872 48 1.0
.init 27 27 0 0.0
.init_array 640 648 8 1.2
.rodata 525877 526293 416 0.1
.text 8999013 9003237 4224 0.0
door-lock-app debug (read only) 2023065 2023065 0 0.0
(read/write) 116928 116928 0 0.0
.bss 47648 47648 0 0.0
.data 992 992 0 0.0
.data.rel.ro 62872 62872 0 0.0
.dynamic 592 592 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 181596 181596 0 0.0
.text 1691586 1691586 0 0.0
lighting-app debug+rpc (read only) 2199433 2199433 0 0.0
(read/write) 123888 123888 0 0.0
.bss 48928 48928 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 67944 67944 0 0.0
.dynamic 608 608 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 175452 175452 0 0.0
.text 1864738 1864738 0 0.0
ota-provider-app debug (read only) 1963457 1963457 0 0.0
(read/write) 112720 112720 0 0.0
.bss 47584 47584 0 0.0
.data 1256 1256 0 0.0
.data.rel.ro 58216 58216 0 0.0
.dynamic 608 608 0 0.0
.got 4384 4384 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 167371 167371 0 0.0
.text 1644146 1644146 0 0.0
ota-requestor-app debug (read only) 1990697 1990697 0 0.0
(read/write) 115944 115944 0 0.0
.bss 48512 48512 0 0.0
.data 1480 1480 0 0.0
.data.rel.ro 60472 60472 0 0.0
.dynamic 592 592 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 163556 163556 0 0.0
.text 1674194 1674194 0 0.0
shell debug (read only) 2451489 2451489 0 0.0
(read/write) 147400 147400 0 0.0
.bss 67304 67304 0 0.0
.data 800 800 0 0.0
.data.rel.ro 73592 73592 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 210066 210066 0 0.0
.text 2084402 2084402 0 0.0
tv-app debug (read only) 2699113 2699113 0 0.0
(read/write) 247552 247552 0 0.0
.bss 164288 164288 0 0.0
.data 3136 3136 0 0.0
.data.rel.ro 74064 74064 0 0.0
.dynamic 592 592 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 206443 206443 0 0.0
.text 2317970 2317970 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2357388 2357388 0 0.0
.bss 185020 185020 0 0.0
.data 5760 5760 0 0.0
.text 1319988 1319988 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1144823 1144823 0 0.0
bss 143052 143052 0 0.0
rodata 142432 142432 0 0.0
text 784496 784496 0 0.0
p6 all-clusters-app default (read/write) 2499976 2499976 0 0.0
.bss 118440 118440 0 0.0
.data 2640 2640 0 0.0
.text 1458240 1458240 0 0.0
light-app default (read/write) 2402144 2402144 0 0.0
.bss 111912 111912 0 0.0
.data 2496 2496 0 0.0
.text 1360408 1360408 0 0.0
lock-app default (read/write) 2365760 2365760 0 0.0
.bss 111656 111656 0 0.0
.data 2456 2456 0 0.0
.text 1324024 1324024 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 789148 789148 0 0.0
bss 70268 70268 0 0.0
noinit 40416 40416 0 0.0
text 559380 559380 0 0.0

@vivien-apple vivien-apple force-pushed the ChipTool_Interactive branch from 6e98f2c to e2f2d65 Compare March 30, 2022 09:35
@github-actions
Copy link

github-actions bot commented Mar 30, 2022 •
edited
Loading

PR #16135: Size comparison from 08906fb to e2f2d65

Increases above 0.2%:

platform target config section 08906fb e2f2d65 change % change
linux chip-tool debug .bss 22464 22528 64 0.3
.dynamic 608 624 16 2.6
.got 4824 4872 48 1.0
.init_array 640 648 8 1.2
Increases (1 build for linux)
platform target config section 08906fb e2f2d65 change % change
linux chip-tool debug (read only) 10311229 10316917 5688 0.1
(read/write) 356456 356784 328 0.1
.bss 22464 22528 64 0.3
.data.rel.ro 326808 327000 192 0.1
.dynamic 608 624 16 2.6
.got 4824 4872 48 1.0
.init_array 640 648 8 1.2
.rodata 525877 526293 416 0.1
.text 8999013 9003237 4224 0.0
Full report (25 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 08906fb e2f2d65 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 606810 606810 0 0.0
.app_xip_area 513580 513580 0 0.0
.bss 75976 75976 0 0.0
.data 604 604 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 564358 564358 0 0.0
.app_xip_area 472656 472656 0 0.0
.bss 74480 74480 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 576538 576538 0 0.0
.app_xip_area 475188 475188 0 0.0
.bss 83808 83808 0 0.0
.data 508 508 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 927928 927928 0 0.0
(read/write) 129112 129112 0 0.0
.bss 127112 127112 0 0.0
.data 1996 1996 0 0.0
.text 927920 927920 0 0.0
BRD4161A+rpc (read only) 956920 956920 0 0.0
(read/write) 145064 145064 0 0.0
.bss 142888 142888 0 0.0
.data 2176 2176 0 0.0
.text 956912 956912 0 0.0
window-app BRD4161A (read only) 857412 857412 0 0.0
(read/write) 127072 127072 0 0.0
.bss 125200 125200 0 0.0
.data 1872 1872 0 0.0
.text 857404 857404 0 0.0
esp32 all-clusters-app c3devkit (read only) 968374 968374 0 0.0
(read/write) 1394770 1394770 0 0.0
.dram0.bss 62416 62416 0 0.0
.dram0.data 14204 14204 0 0.0
.flash.rodata 199240 199240 0 0.0
.flash.text 968374 968374 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1024075 1024075 0 0.0
(read/write) 462532 462532 0 0.0
.dram0.bss 67944 67944 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 228728 228728 0 0.0
.flash.text 1018691 1018691 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 705392 705392 0 0.0
.bss 77968 77968 0 0.0
.data 1876 1876 0 0.0
.text 619748 619748 0 0.0
lock k32w061+release (read/write) 704508 704508 0 0.0
.bss 77944 77944 0 0.0
.data 1916 1916 0 0.0
.text 618848 618848 0 0.0
linux all-clusters-app debug (read only) 2536721 2536721 0 0.0
(read/write) 143384 143384 0 0.0
.bss 57408 57408 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 78952 78952 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 944 944 0 0.0
.rodata 216613 216613 0 0.0
.text 2156210 2156210 0 0.0
bridge-app debug+rpc (read only) 1770437 1770437 0 0.0
(read/write) 89552 89552 0 0.0
.bss 44520 44520 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 37968 37968 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 145004 145004 0 0.0
.text 1510005 1510005 0 0.0
chip-tool debug (read only) 10311229 10316917 5688 0.1
(read/write) 356456 356784 328 0.1
.bss 22464 22528 64 0.3
.data 1072 1072 0 0.0
.data.rel.ro 326808 327000 192 0.1
.dynamic 608 624 16 2.6
.got 4824 4872 48 1.0
.init 27 27 0 0.0
.init_array 640 648 8 1.2
.rodata 525877 526293 416 0.1
.text 8999013 9003237 4224 0.0
door-lock-app debug (read only) 2023065 2023065 0 0.0
(read/write) 116928 116928 0 0.0
.bss 47648 47648 0 0.0
.data 992 992 0 0.0
.data.rel.ro 62872 62872 0 0.0
.dynamic 592 592 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 181596 181596 0 0.0
.text 1691586 1691586 0 0.0
lighting-app debug+rpc (read only) 2199433 2199433 0 0.0
(read/write) 123888 123888 0 0.0
.bss 48928 48928 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 67944 67944 0 0.0
.dynamic 608 608 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 175452 175452 0 0.0
.text 1864738 1864738 0 0.0
ota-provider-app debug (read only) 1963457 1963457 0 0.0
(read/write) 112720 112720 0 0.0
.bss 47584 47584 0 0.0
.data 1256 1256 0 0.0
.data.rel.ro 58216 58216 0 0.0
.dynamic 608 608 0 0.0
.got 4384 4384 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 167371 167371 0 0.0
.text 1644146 1644146 0 0.0
ota-requestor-app debug (read only) 1990697 1990697 0 0.0
(read/write) 115944 115944 0 0.0
.bss 48512 48512 0 0.0
.data 1480 1480 0 0.0
.data.rel.ro 60472 60472 0 0.0
.dynamic 592 592 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 163556 163556 0 0.0
.text 1674194 1674194 0 0.0
shell debug (read only) 2451489 2451489 0 0.0
(read/write) 147400 147400 0 0.0
.bss 67304 67304 0 0.0
.data 800 800 0 0.0
.data.rel.ro 73592 73592 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 210066 210066 0 0.0
.text 2084402 2084402 0 0.0
tv-app debug (read only) 2699113 2699113 0 0.0
(read/write) 247552 247552 0 0.0
.bss 164288 164288 0 0.0
.data 3136 3136 0 0.0
.data.rel.ro 74064 74064 0 0.0
.dynamic 592 592 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 206443 206443 0 0.0
.text 2317970 2317970 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2357388 2357388 0 0.0
.bss 185020 185020 0 0.0
.data 5760 5760 0 0.0
.text 1319988 1319988 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1144823 1144823 0 0.0
bss 143052 143052 0 0.0
rodata 142432 142432 0 0.0
text 784496 784496 0 0.0
p6 all-clusters-app default (read/write) 2499976 2499976 0 0.0
.bss 118440 118440 0 0.0
.data 2640 2640 0 0.0
.text 1458240 1458240 0 0.0
light-app default (read/write) 2402144 2402144 0 0.0
.bss 111912 111912 0 0.0
.data 2496 2496 0 0.0
.text 1360408 1360408 0 0.0
lock-app default (read/write) 2365760 2365760 0 0.0
.bss 111656 111656 0 0.0
.data 2456 2456 0 0.0
.text 1324024 1324024 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 789148 789148 0 0.0
bss 70268 70268 0 0.0
noinit 40416 40416 0 0.0
text 559380 559380 0 0.0

@vivien-apple vivien-apple force-pushed the ChipTool_Interactive branch 2 times, most recently from 8c553b9 to c3c1b68 Compare March 30, 2022 12:26
@github-actions
Copy link

github-actions bot commented Mar 30, 2022 •
edited
Loading

PR #16135: Size comparison from 08906fb to c3c1b68

Increases above 0.2%:

platform target config section 08906fb c3c1b68 change % change
linux chip-tool debug .bss 22464 22528 64 0.3
.dynamic 608 624 16 2.6
.got 4824 4872 48 1.0
.init_array 640 648 8 1.2
Increases (1 build for linux)
platform target config section 08906fb c3c1b68 change % change
linux chip-tool debug (read only) 10311229 10316917 5688 0.1
(read/write) 356456 356784 328 0.1
.bss 22464 22528 64 0.3
.data.rel.ro 326808 327000 192 0.1
.dynamic 608 624 16 2.6
.got 4824 4872 48 1.0
.init_array 640 648 8 1.2
.rodata 525877 526293 416 0.1
.text 8999013 9003237 4224 0.0
Full report (23 builds for cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 08906fb c3c1b68 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 606810 606810 0 0.0
.app_xip_area 513580 513580 0 0.0
.bss 75976 75976 0 0.0
.data 604 604 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 564358 564358 0 0.0
.app_xip_area 472656 472656 0 0.0
.bss 74480 74480 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 576538 576538 0 0.0
.app_xip_area 475188 475188 0 0.0
.bss 83808 83808 0 0.0
.data 508 508 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 927928 927928 0 0.0
(read/write) 129112 129112 0 0.0
.bss 127112 127112 0 0.0
.data 1996 1996 0 0.0
.text 927920 927920 0 0.0
BRD4161A+rpc (read only) 956920 956920 0 0.0
(read/write) 145064 145064 0 0.0
.bss 142888 142888 0 0.0
.data 2176 2176 0 0.0
.text 956912 956912 0 0.0
window-app BRD4161A (read only) 857412 857412 0 0.0
(read/write) 127072 127072 0 0.0
.bss 125200 125200 0 0.0
.data 1872 1872 0 0.0
.text 857404 857404 0 0.0
k32w light k32w061+release (read/write) 705392 705392 0 0.0
.bss 77968 77968 0 0.0
.data 1876 1876 0 0.0
.text 619748 619748 0 0.0
lock k32w061+release (read/write) 704508 704508 0 0.0
.bss 77944 77944 0 0.0
.data 1916 1916 0 0.0
.text 618848 618848 0 0.0
linux all-clusters-app debug (read only) 2536721 2536721 0 0.0
(read/write) 143384 143384 0 0.0
.bss 57408 57408 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 78952 78952 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 944 944 0 0.0
.rodata 216613 216613 0 0.0
.text 2156210 2156210 0 0.0
bridge-app debug+rpc (read only) 1770437 1770437 0 0.0
(read/write) 89552 89552 0 0.0
.bss 44520 44520 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 37968 37968 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 145004 145004 0 0.0
.text 1510005 1510005 0 0.0
chip-tool debug (read only) 10311229 10316917 5688 0.1
(read/write) 356456 356784 328 0.1
.bss 22464 22528 64 0.3
.data 1072 1072 0 0.0
.data.rel.ro 326808 327000 192 0.1
.dynamic 608 624 16 2.6
.got 4824 4872 48 1.0
.init 27 27 0 0.0
.init_array 640 648 8 1.2
.rodata 525877 526293 416 0.1
.text 8999013 9003237 4224 0.0
door-lock-app debug (read only) 2023065 2023065 0 0.0
(read/write) 116928 116928 0 0.0
.bss 47648 47648 0 0.0
.data 992 992 0 0.0
.data.rel.ro 62872 62872 0 0.0
.dynamic 592 592 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 181596 181596 0 0.0
.text 1691586 1691586 0 0.0
lighting-app debug+rpc (read only) 2199433 2199433 0 0.0
(read/write) 123888 123888 0 0.0
.bss 48928 48928 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 67944 67944 0 0.0
.dynamic 608 608 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 175452 175452 0 0.0
.text 1864738 1864738 0 0.0
ota-provider-app debug (read only) 1963457 1963457 0 0.0
(read/write) 112720 112720 0 0.0
.bss 47584 47584 0 0.0
.data 1256 1256 0 0.0
.data.rel.ro 58216 58216 0 0.0
.dynamic 608 608 0 0.0
.got 4384 4384 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 167371 167371 0 0.0
.text 1644146 1644146 0 0.0
ota-requestor-app debug (read only) 1990697 1990697 0 0.0
(read/write) 115944 115944 0 0.0
.bss 48512 48512 0 0.0
.data 1480 1480 0 0.0
.data.rel.ro 60472 60472 0 0.0
.dynamic 592 592 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 163556 163556 0 0.0
.text 1674194 1674194 0 0.0
shell debug (read only) 2451489 2451489 0 0.0
(read/write) 147400 147400 0 0.0
.bss 67304 67304 0 0.0
.data 800 800 0 0.0
.data.rel.ro 73592 73592 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 210066 210066 0 0.0
.text 2084402 2084402 0 0.0
tv-app debug (read only) 2699113 2699113 0 0.0
(read/write) 247552 247552 0 0.0
.bss 164288 164288 0 0.0
.data 3136 3136 0 0.0
.data.rel.ro 74064 74064 0 0.0
.dynamic 592 592 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 206443 206443 0 0.0
.text 2317970 2317970 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2357388 2357388 0 0.0
.bss 185020 185020 0 0.0
.data 5760 5760 0 0.0
.text 1319988 1319988 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1144823 1144823 0 0.0
bss 143052 143052 0 0.0
rodata 142432 142432 0 0.0
text 784496 784496 0 0.0
p6 all-clusters-app default (read/write) 2499976 2499976 0 0.0
.bss 118440 118440 0 0.0
.data 2640 2640 0 0.0
.text 1458240 1458240 0 0.0
light-app default (read/write) 2402144 2402144 0 0.0
.bss 111912 111912 0 0.0
.data 2496 2496 0 0.0
.text 1360408 1360408 0 0.0
lock-app default (read/write) 2365760 2365760 0 0.0
.bss 111656 111656 0 0.0
.data 2456 2456 0 0.0
.text 1324024 1324024 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 789148 789148 0 0.0
bss 70268 70268 0 0.0
noinit 40416 40416 0 0.0
text 559380 559380 0 0.0

@vivien-apple vivien-apple force-pushed the ChipTool_Interactive branch from c3c1b68 to b8e8465 Compare March 30, 2022 13:19
@github-actions
Copy link

github-actions bot commented Mar 30, 2022 •
edited
Loading

PR #16135: Size comparison from b80df3d to b8e8465

Increases above 0.2%:

platform target config section b80df3dc b8e8465 change % change
linux chip-tool debug .bss 22464 22528 64 0.3
.dynamic 608 624 16 2.6
.got 4824 4872 48 1.0
.init_array 640 648 8 1.2
Increases (1 build for linux)
platform target config section b80df3dc b8e8465 change % change
linux chip-tool debug (read only) 10311229 10316917 5688 0.1
(read/write) 356456 356784 328 0.1
.bss 22464 22528 64 0.3
.data.rel.ro 326808 327000 192 0.1
.dynamic 608 624 16 2.6
.got 4824 4872 48 1.0
.init_array 640 648 8 1.2
.rodata 525877 526293 416 0.1
.text 8999013 9003237 4224 0.0
Full report (26 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section b80df3dc b8e8465 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 607198 607198 0 0.0
.app_xip_area 513968 513968 0 0.0
.bss 75976 75976 0 0.0
.data 604 604 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 564738 564738 0 0.0
.app_xip_area 473036 473036 0 0.0
.bss 74480 74480 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 576874 576874 0 0.0
.app_xip_area 475524 475524 0 0.0
.bss 83808 83808 0 0.0
.data 508 508 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 927928 927928 0 0.0
(read/write) 129112 129112 0 0.0
.bss 127112 127112 0 0.0
.data 1996 1996 0 0.0
.text 927920 927920 0 0.0
BRD4161A+rpc (read only) 956920 956920 0 0.0
(read/write) 145064 145064 0 0.0
.bss 142888 142888 0 0.0
.data 2176 2176 0 0.0
.text 956912 956912 0 0.0
window-app BRD4161A (read only) 857412 857412 0 0.0
(read/write) 127072 127072 0 0.0
.bss 125200 125200 0 0.0
.data 1872 1872 0 0.0
.text 857404 857404 0 0.0
esp32 all-clusters-app c3devkit (read only) 968374 968374 0 0.0
(read/write) 1394770 1394770 0 0.0
.dram0.bss 62416 62416 0 0.0
.dram0.data 14204 14204 0 0.0
.flash.rodata 199240 199240 0 0.0
.flash.text 968374 968374 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1024075 1024075 0 0.0
(read/write) 462532 462532 0 0.0
.dram0.bss 67944 67944 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 228728 228728 0 0.0
.flash.text 1018691 1018691 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 705780 705780 0 0.0
.bss 77968 77968 0 0.0
.data 1876 1876 0 0.0
.text 620136 620136 0 0.0
lock k32w061+release (read/write) 704900 704900 0 0.0
.bss 77944 77944 0 0.0
.data 1916 1916 0 0.0
.text 619240 619240 0 0.0
linux all-clusters-app debug (read only) 2537441 2537441 0 0.0
(read/write) 143384 143384 0 0.0
.bss 57408 57408 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 78952 78952 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 944 944 0 0.0
.rodata 216613 216613 0 0.0
.text 2156930 2156930 0 0.0
bridge-app debug+rpc (read only) 1771221 1771221 0 0.0
(read/write) 89552 89552 0 0.0
.bss 44520 44520 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 37968 37968 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 145004 145004 0 0.0
.text 1510789 1510789 0 0.0
chip-tool debug (read only) 10311229 10316917 5688 0.1
(read/write) 356456 356784 328 0.1
.bss 22464 22528 64 0.3
.data 1072 1072 0 0.0
.data.rel.ro 326808 327000 192 0.1
.dynamic 608 624 16 2.6
.got 4824 4872 48 1.0
.init 27 27 0 0.0
.init_array 640 648 8 1.2
.rodata 525877 526293 416 0.1
.text 8999013 9003237 4224 0.0
door-lock-app debug (read only) 2023865 2023865 0 0.0
(read/write) 116928 116928 0 0.0
.bss 47648 47648 0 0.0
.data 992 992 0 0.0
.data.rel.ro 62872 62872 0 0.0
.dynamic 592 592 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 181596 181596 0 0.0
.text 1692386 1692386 0 0.0
lighting-app debug+rpc (read only) 2200153 2200153 0 0.0
(read/write) 123888 123888 0 0.0
.bss 48928 48928 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 67944 67944 0 0.0
.dynamic 608 608 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 175452 175452 0 0.0
.text 1865458 1865458 0 0.0
ota-provider-app debug (read only) 1964257 1964257 0 0.0
(read/write) 112720 112720 0 0.0
.bss 47584 47584 0 0.0
.data 1256 1256 0 0.0
.data.rel.ro 58216 58216 0 0.0
.dynamic 608 608 0 0.0
.got 4384 4384 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 167371 167371 0 0.0
.text 1644946 1644946 0 0.0
ota-requestor-app debug (read only) 1991481 1991481 0 0.0
(read/write) 115944 115944 0 0.0
.bss 48512 48512 0 0.0
.data 1480 1480 0 0.0
.data.rel.ro 60472 60472 0 0.0
.dynamic 592 592 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 163556 163556 0 0.0
.text 1674978 1674978 0 0.0
shell debug (read only) 2452209 2452209 0 0.0
(read/write) 147400 147400 0 0.0
.bss 67304 67304 0 0.0
.data 800 800 0 0.0
.data.rel.ro 73592 73592 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 210066 210066 0 0.0
.text 2085122 2085122 0 0.0
thermostat-no-ble arm64 (read only) 2281796 2281796 0 0.0
(read/write) 148353 148353 0 0.0
.bss 62817 62817 0 0.0
.data 1040 1040 0 0.0
.data.rel.ro 76976 76976 0 0.0
.dynamic 560 560 0 0.0
.got 4512 4512 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 140116 140116 0 0.0
.text 1918272 1918272 0 0.0
tv-app debug (read only) 2699817 2699817 0 0.0
(read/write) 247552 247552 0 0.0
.bss 164288 164288 0 0.0
.data 3136 3136 0 0.0
.data.rel.ro 74064 74064 0 0.0
.dynamic 592 592 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 206443 206443 0 0.0
.text 2318674 2318674 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2357388 2357388 0 0.0
.bss 185020 185020 0 0.0
.data 5760 5760 0 0.0
.text 1319988 1319988 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1145211 1145211 0 0.0
bss 143052 143052 0 0.0
rodata 142516 142516 0 0.0
text 784788 784788 0 0.0
p6 all-clusters-app default (read/write) 2499976 2499976 0 0.0
.bss 118440 118440 0 0.0
.data 2640 2640 0 0.0
.text 1458240 1458240 0 0.0
light-app default (read/write) 2402144 2402144 0 0.0
.bss 111912 111912 0 0.0
.data 2496 2496 0 0.0
.text 1360408 1360408 0 0.0
lock-app default (read/write) 2365760 2365760 0 0.0
.bss 111656 111656 0 0.0
.data 2456 2456 0 0.0
.text 1324024 1324024 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 789580 789580 0 0.0
bss 70268 70268 0 0.0
noinit 40416 40416 0 0.0
text 559722 559722 0 0.0

@vivien-apple vivien-apple merged commit 11ab5a3 into project-chip:master Mar 30, 2022
@bpetersen-grundfos bpetersen-grundfos mentioned this pull request Mar 31, 2022
Closed
rochaferraz pushed a commit to rochaferraz/connectedhomeip that referenced this pull request Mar 31, 2022
@vivien-apple @rochaferraz
Chip tool interactive (project-chip#16135)
aef0356 
* [chip-tool] Add chip-tool interactive mode

* Update generated content

* Allow interactive mode to be disabled for some build variants
@RudyGOGOGO RudyGOGOGO mentioned this pull request Mar 31, 2022
Closed
andy31415 added a commit to andy31415/connectedhomeip that referenced this pull request Apr 5, 2022
@andy31415
Add libreadline-dev to docker images after project-chip#16135 added i…
1682a4b 
…t as a requirement
@andy31415 andy31415 mentioned this pull request Apr 5, 2022
Merged
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this pull request Apr 14, 2022
@vivien-apple @andrei-menzopol
Chip tool interactive (project-chip#16135)
4e49fcf 
* [chip-tool] Add chip-tool interactive mode

* Update generated content

* Allow interactive mode to be disabled for some build variants
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees

@vivien-apple vivien-apple

Labels
examples fast track github review - pending scripts workflows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vivien-apple @woody-apple @bzbarsky-apple