Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement access control for IM invoke (group) #14541

Closed
mlepage-google opened this issue Jan 28, 2022 · 1 comment
Closed

Implement access control for IM invoke (group) #14541

mlepage-google opened this issue Jan 28, 2022 · 1 comment
Assignees
@mlepage-google
Labels
acl Access Control feature Interaction Model Work V1.0

Comments

@mlepage-google
Copy link
Contributor

CommandHandler::ProcessGroupCommandDataIB has added another place where IM is processing actions (in this case for group) and therefore checking access control.

This needs to be gone over to ensure handling is correct. (E.g. fatal errors are handled)

Also needs end to end testing.
@mlepage-google
Copy link
Contributor Author

@mkardous-silabs FYI

mlepage-google added a commit to mlepage-google/connectedhomeip that referenced this issue Feb 11, 2022
@mlepage-google
Hook up GetSubjectDescriptor in GroupSession
743974d 
Progress toward project-chip#14541
@mlepage-google mlepage-google mentioned this issue Feb 11, 2022
Merged
mlepage-google added a commit that referenced this issue Feb 11, 2022
@mlepage-google
Hook up GetSubjectDescriptor in GroupSession (#15091)
23d423f 
Progress toward #14541
mlepage-google added a commit to mlepage-google/connectedhomeip that referenced this issue Apr 6, 2022
@mlepage-google
Change TODO to NOTE in ProcessGroupCommandDataIB
8d471ea 
There's not much else to do here, so change the TODO to a NOTE.

Fixes issue project-chip#14541
@mlepage-google mlepage-google mentioned this issue Apr 6, 2022
Merged
andy31415 pushed a commit that referenced this issue Apr 7, 2022
@mlepage-google
Change TODO to NOTE in ProcessGroupCommandDataIB (#17147)
b3203bb 
There's not much else to do here, so change the TODO to a NOTE.

Fixes issue #14541
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this issue Apr 14, 2022
@mlepage-google @andrei-menzopol
Change TODO to NOTE in ProcessGroupCommandDataIB (project-chip#17147)
6d2afe1 
There's not much else to do here, so change the TODO to a NOTE.

Fixes issue project-chip#14541
jamesluo11 pushed a commit to jamesluo11/connectedhomeip that referenced this issue Apr 26, 2022
@mlepage-google @fuxingguo16
Hook up GetSubjectDescriptor in GroupSession (project-chip#15091)
9f0ad01 
Progress toward project-chip#14541
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mlepage-google mlepage-google

Labels
acl Access Control feature Interaction Model Work V1.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@andy31415 @cecille @mlepage-google