Skip to content

Commit

Permalink
Change TODO to NOTE in ProcessGroupCommandDataIB (#17147)
Browse files Browse the repository at this point in the history
There's not much else to do here, so change the TODO to a NOTE.

Fixes issue #14541
  • Loading branch information
mlepage-google authored Apr 7, 2022
1 parent 306e8a4 commit b3203bb
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/app/CommandHandler.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,9 @@ CHIP_ERROR CommandHandler::ProcessGroupCommandDataIB(CommandDataIB::Parser & aCo
err = Access::GetAccessControl().Check(subjectDescriptor, requestPath, requestPrivilege);
if (err != CHIP_NO_ERROR)
{
// TODO: handle errors that aren't CHIP_ERROR_ACCESS_DENIED, etc.
// NOTE: an expected error is CHIP_ERROR_ACCESS_DENIED, but there could be other unexpected errors;
// therefore, keep processing subsequent commands, and if any errors continue, those subsequent
// commands will likewise fail.
continue;
}
}
Expand Down

0 comments on commit b3203bb

Please sign in to comment.