Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Q Upgrade policy, what has been patched, .. #8

Closed
MangoIV opened this issue Feb 18, 2023 · 3 comments
Closed

Q Upgrade policy, what has been patched, .. #8

MangoIV opened this issue Feb 18, 2023 · 3 comments
Labels
documentation Improvements or additions to documentation

Comments

@MangoIV
Copy link

MangoIV commented Feb 18, 2023

Hi, I would like to ask whether this is going to be updated regularly. I'd really like to use it but I fear that this will just fall behind...

Additionally I would like to ask, whether it's possible to not have this as a fork but rather as a curated patchset so it's easier to see what is actually changed without grepping through the history.

Thanks in advance and thank you for making this.

@MangoIV MangoIV added the documentation Improvements or additions to documentation label Feb 18, 2023
@max-privatevoid
Copy link
Member

The current update policy is "I'll merge nixos/master every once in a while or if there's a shiny new feature upstream that I want to use". It might be a good idea to automate this with Hercules CI scheduled effects. Weekly updates sounds good, I think.
Relevant to current state: Upstream seems to be broken on master currently (NixOS/nix#7856), so I'll hold off on updates for a bit until that situation gets resolved.

The original version of this project was a curated patchset (https://git.privatevoid.net/max/nix-super-archived). I switched away from that model because fixing patch conflicts after updating the upstream rev was a tedious task. Taking advantage of Git's conflict resolution capabilities makes this a nicer experience. I'd be okay with changing it back to the patchset style if you know a decent workflow for it. Having a place where all the changes in this fork are documented could be a decent solution to your problem as well.

@MangoIV
Copy link
Author

MangoIV commented Feb 27, 2023

I switched away from that model because fixing patch conflicts after updating the upstream rev was a tedious task

that makes sense, thank you for clarifying

"I'll merge nixos/master every once in a while or if there's a shiny new feature upstream that I want to use"

haha, okay, I'll roll with this >3

Thank you for making this!

@MangoIV MangoIV closed this as completed Apr 14, 2023
@UserSv4
Copy link

UserSv4 commented Nov 15, 2023

I'd be okay with changing it back to the patchset style if you know a decent workflow for it.
@max-privatevoid How about something like:

git clone https://git.privatevoid.net/max/nix-super-archived
git clone https://github.com/nixos/nix
git fetch
git restore .
cd nix
for patch in ../nix-super-archived/patches/*
	git reset --hard 4369771870b3945f95e1468a0803696034d506b7 # replace with the latest known commit with no conflicts
	patch -p1 < $patch
	git commit -am "Changes"
	git merge origin/master
	$SHELL # fix the conflicts and then exit the shell
	git diff > $patch.new
end

max-privatevoid pushed a commit that referenced this issue Apr 19, 2024
Implement deduplication and add more test cases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants