-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wait with making /etc unwritable until after build env setup #7856
Conversation
This fixes /etc/nsswitch.conf
|
(Since the previous fix that this amends was also backported to 2.12 and 2.13, please add those labels here, @ whichever maintainer gets to this first :D) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Git push to origin failed for 2.12-maintenance with exitcode 1 |
Successfully created backport PR for |
Successfully created backport PR for |
Git push to origin failed for 2.13-maintenance with exitcode 1 |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/tweag-nix-dev-update-45/26397/1 |
Motivation
The builder child still has to touch /etc to setup nsswitch.conf and bind mounts. Wait until after this to make /etc unwritable.
Context
Fixes #7852. Was broken in #7830.
Checklist for maintainers
Maintainers: tick if completed or explain if not relevant
tests/**.sh
src/*/tests
tests/nixos/*