Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Proton Pass & password management page updates #2459

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Add Proton Pass & password management page updates #2459

merged 1 commit into from
Apr 10, 2024

Conversation

rollsicecream
Copy link
Contributor

Changes proposed in this PR:

  • Update Password Management page:

    • Update Recommendations cards of Bitwarden and 1Password to reflect new download platforms (e.g. Safari) and passkey management.

    • Recommends Proton Pass (as the relevant forum post has been approved).

  • I have disclosed any relevant conflicts of interest in my post.
  • I agree to grant Privacy Guides a perpetual, worldwide, non-exclusive, transferable, royalty-free, irrevocable license with the right to sublicense such rights through multiple tiers of sublicensees, to reproduce, modify, display, perform, relicense, and distribute my contribution as part of this project.
  • I am the sole author of this work.
  • I agree to the Community Code of Conduct.

@netlify Netlify
Copy link

netlify bot commented Mar 30, 2024 •
edited
Loading

✅ Deploy Preview for privacyguides ready!

Name Link
🔨 Latest commit 12de017
🔍 Latest deploy log https://app.netlify.com/sites/privacyguides/deploys/6608ece493a3bd0008b791a7
😎 Deploy Preview https://deploy-preview-2459.preview.privacyguides.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 4 paths audited
Performance: 77 (🟢 up 1 from production)
Accessibility: 91 (🔴 down 1 from production)
Best Practices: 81 (🔴 down 17 from production)
SEO: 90 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@rollsicecream rollsicecream changed the title Update Password Management page Update Password Management page + Recommend Proton Pass Mar 30, 2024
@jonaharagon jonaharagon changed the title Update Password Management page + Recommend Proton Pass Add Proton Pass & password management page updates Mar 30, 2024
jonaharagon
jonaharagon approved these changes Mar 31, 2024
View reviewed changes
Copy link
Member

@jonaharagon jonaharagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@dngray dngray added the c:software self-hosted/decentralized software and related topics label Mar 31, 2024
redoomed1
redoomed1 requested changes Mar 31, 2024
View reviewed changes
docs/passwords.md Show resolved Hide resolved
docs/passwords.md Show resolved Hide resolved
jonaharagon pushed a commit to rollsicecream/privacyguides-fork that referenced this pull request Mar 31, 2024
@rollsicecream @redoomed1 @jonaharagon
Update Password Management page (privacyguides#2459)
6afa80d 
Signed-off-by: Jonah Aragon <jonah@triplebit.net>
Co-Authored-By: redoomed1 <161974310+redoomed1@users.noreply.github.com>
jonaharagon pushed a commit to rollsicecream/privacyguides-fork that referenced this pull request Mar 31, 2024
@rollsicecream @redoomed1 @jonaharagon
Update Password Management page (privacyguides#2459)
12de017 
Signed-off-by: Jonah Aragon <jonah@triplebit.net>
Co-Authored-By: redoomed1 <161974310+redoomed1@users.noreply.github.com>
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 31, 2024 •
edited
Loading

✅ Your preview is ready!

Name Link
🔨 Latest commit 65bc92a
😎 Preview https://65bc92af883a--glowing-salamander-8d7127.netlify.app/

@jonaharagon jonaharagon force-pushed the main branch 4 times, most recently from e124ecf to 82ab189 Compare March 31, 2024 09:04
rollsicecream added a commit to rollsicecream/privacyguides-fork that referenced this pull request Mar 31, 2024
@rollsicecream @redoomed1
Update Password Management page (privacyguides#2459)
9b5eb9a 
Signed-off-by: Jonah Aragon <jonah@triplebit.net>
Co-Authored-By: redoomed1 <161974310+redoomed1@users.noreply.github.com>
@rollsicecream
Copy link
Contributor Author

rollsicecream commented Mar 31, 2024 •
edited
Loading

I think it's all good now, should we make any changes?

redoomed1
redoomed1 requested changes Mar 31, 2024
View reviewed changes
Copy link
Member

@redoomed1 redoomed1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing this description, @rollsicecream ! I just have a few notes on formatting and wording.

docs/passwords.md Outdated Show resolved Hide resolved
docs/passwords.md Outdated Show resolved Hide resolved
docs/passwords.md Outdated Show resolved Hide resolved
redoomed1
redoomed1 reviewed Mar 31, 2024
View reviewed changes
docs/passwords.md Outdated Show resolved Hide resolved
@rollsicecream
Copy link
Contributor Author

Oof, that was a lot of great changes thanks to @redoomed1. Normally, everything should be good.

jonaharagon
jonaharagon reviewed Apr 3, 2024
View reviewed changes
docs/passwords.md Outdated Show resolved Hide resolved
@jonaharagon jonaharagon requested a review from dngray April 3, 2024 04:47
@jonaharagon jonaharagon force-pushed the main branch 5 times, most recently from 91e0dc7 to af45bcc Compare April 6, 2024 05:42
freddy-m
freddy-m reviewed Apr 8, 2024
View reviewed changes
docs/passwords.md Outdated Show resolved Hide resolved
freddy-m
freddy-m approved these changes Apr 8, 2024
View reviewed changes
Copy link
Member

@freddy-m freddy-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for the PR!

@rollsicecream @redoomed1 @jonaharagon
Update Password Management page (privacyguides#2459)
65bc92a 
Signed-off-by: Jonah Aragon <jonah@privacyguides.org>
Signed-off-by: Freddy <freddy@privacyguides.org>
Co-Authored-By: redoomed1 <161974310+redoomed1@users.noreply.github.com>
@jonaharagon jonaharagon merged commit 65bc92a into privacyguides:main Apr 10, 2024
23 checks passed
@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.net/t/2024-04-10/17801/1

@rollsicecream rollsicecream deleted the password-managers branch August 5, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonaharagon jonaharagon jonaharagon approved these changes

@redoomed1 redoomed1 redoomed1 requested changes

@freddy-m freddy-m freddy-m approved these changes

@dngray dngray Awaiting requested review from dngray

Assignees
No one assigned
Labels
c:software self-hosted/decentralized software and related topics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rollsicecream @privacyguides-bot @jonaharagon @freddy-m @redoomed1 @dngray