Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lints #312

Merged
merged 30 commits into from
Feb 4, 2025
Merged
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
33f9da5
MaterialStateProperty -> WidgetStateProperty
w-ensink Jan 23, 2025
f369514
fix super.key lint and library name lint
w-ensink Jan 23, 2025
b7d1787
fix context async gap linter warnings
w-ensink Jan 23, 2025
b5ac929
Merge branch 'voiceover' into fix-lints
w-ensink Jan 23, 2025
672150c
add correct place to access inherited widget
w-ensink Jan 23, 2025
f4e1354
replace WillPopScope for PopScope
w-ensink Jan 23, 2025
90fc8a4
fix some deprecation warnings
w-ensink Jan 23, 2025
37a10d4
fix pop scope in router
w-ensink Jan 23, 2025
73db921
update podspec
w-ensink Jan 23, 2025
187774d
turn off impeller on android
w-ensink Jan 23, 2025
4d1c2b5
fix some issues with navigation
w-ensink Jan 24, 2025
62469c6
fix more linter warnings
w-ensink Jan 24, 2025
add3fee
fix more linter warnings
w-ensink Jan 24, 2025
f52d0fb
fix runtime type matching switch cases
w-ensink Jan 24, 2025
511060b
Merge branch 'voiceover' into fix-lints
w-ensink Jan 24, 2025
79f63fc
fix double dismiss on Android
w-ensink Jan 29, 2025
c68700e
don't print IrmaConfigurationEvent payload
w-ensink Jan 29, 2025
9448006
clean up irma repository a bit
w-ensink Jan 30, 2025
243da21
fix some tests
w-ensink Jan 30, 2025
04c24f2
remove deprecated preferences get() method
w-ensink Jan 30, 2025
3d5b5cc
put initState code in didChangeDependencies
w-ensink Jan 30, 2025
1f314f9
update launcher icons and code gen commands
w-ensink Jan 30, 2025
5bf87c4
remove returnUrl on SessionPointer
w-ensink Jan 30, 2025
40218ed
update change logs
w-ensink Jan 31, 2025
82c3824
fix multiple inits of late final variable
w-ensink Jan 31, 2025
48f5c9f
Merge branch 'master' into fix-lints
w-ensink Jan 31, 2025
bb14fa7
fix multiple inits where it should be one
w-ensink Feb 3, 2025
202e4a9
remove redundant comments
w-ensink Feb 3, 2025
71e7547
fix multiple inits & optimized PopScope
w-ensink Feb 3, 2025
a6de7c8
allow multiple inits for irma repo field
w-ensink Feb 4, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix double dismiss on Android
the onPopInvokedWithResult callback would be triggered by the close
button, which meant onDismiss would be called twice
  • Loading branch information
w-ensink committed Jan 29, 2025
commit 79f63fcb959636b5f0a6bbb69e40246d9fd81840
3 changes: 0 additions & 3 deletions lib/src/widgets/action_feedback.dart
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,6 @@ class ActionFeedback extends StatelessWidget {

return PopScope(
canPop: false,
onPopInvokedWithResult: (didPop, popResult) {
onDismiss();
},
child: SessionScaffold(
appBarTitle: success ? 'disclosure.feedback.header.success' : 'ui.error',
onDismiss: onDismiss,
Expand Down