Fix lints #312
Open
Fix lints #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and some other deprecated stuff
- gives rendering problem in QR scanner where it renders a black square where it should be transparent in the view finder
- introduced by using PopScope instead of WillPopScope
apparently there is a significant difference between `case Type:` and `case Type _:`
the onPopInvokedWithResult callback would be triggered by the close button, which meant onDismiss would be called twice
- it was simply bloating the logs
- required a little bit of a hack in the sentry code with a global variable
- because initState doesn't have access to the build context
- it was deprecated and wasn't being used anywhere (it seems)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #310
Aims to fix #311
Also fixes #304
Also works around #313 by disabling Impeller on Android