Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hive session property to disable stats based filter reordering #24630

Merged
merged 1 commit into from
Feb 26, 2025
+8 −1
Merged

Add hive session property to disable stats based filter reordering #24630

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion presto-hive/src/main/java/com/facebook/presto/hive/HiveSessionProperties.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,8 @@ public final class HiveSessionProperties
public static final String SKIP_EMPTY_FILES = "skip_empty_files";
public static final String LEGACY_TIMESTAMP_BUCKETING = "legacy_timestamp_bucketing";

public static final String STATS_BASED_FILTER_REORDER_DISABLED = "stats_based_filter_reorder_disabled";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to add native prefix as the other native only session properties?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, but looks like the naming conversion only exists for system session property, connector specific ones we don't have.

Maybe we can add that in the follow up as long term solution


private final List<PropertyMetadata<?>> sessionProperties;

@Inject
Expand Down Expand Up @@ -647,7 +649,12 @@ public HiveSessionProperties(HiveClientConfig hiveClientConfig, OrcFileWriterCon
LEGACY_TIMESTAMP_BUCKETING,
"Use legacy timestamp bucketing algorithm (which is not Hive compatible) for table bucketed by timestamp type.",
hiveClientConfig.isLegacyTimestampBucketing(),
false));
false),
booleanProperty(
STATS_BASED_FILTER_REORDER_DISABLED,
"Native Execution only. Disable stats based filter reordering.",
false,
true));
}

public List<PropertyMetadata<?>> getSessionProperties()
Expand Down
Loading