Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hive session property to disable stats based filter reordering #24630

Merged
merged 1 commit into from
Feb 26, 2025
Merged

Add hive session property to disable stats based filter reordering #24630

merged 1 commit into from
Feb 26, 2025

Conversation

kewang1024
Copy link
Collaborator 

== RELEASE NOTES ==
Hive Connector Changes
* Add session property ``hive.stats_based_filter_reorder_disabled`` for disabling reader stats based filter reordering

@prestodb-ci prestodb-ci added the from:Meta PR from Meta label Feb 26, 2025
xiaoxmeng
xiaoxmeng previously approved these changes Feb 26, 2025
View reviewed changes
presto-hive/src/main/java/com/facebook/presto/hive/HiveSessionProperties.java
@@ -134,6 +134,8 @@ public final class HiveSessionProperties
public static final String SKIP_EMPTY_FILES = "skip_empty_files";
public static final String LEGACY_TIMESTAMP_BUCKETING = "legacy_timestamp_bucketing";

public static final String STATS_BASED_FILTER_REORDER_DISABLED = "stats_based_filter_reorder_disabled";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to add native prefix as the other native only session properties?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, but looks like the naming conversion only exists for system session property, connector specific ones we don't have.

Maybe we can add that in the follow up as long term solution

@kewang1024 kewang1024 marked this pull request as ready for review February 26, 2025 17:13
@kewang1024 kewang1024 requested a review from a team as a code owner February 26, 2025 17:13
@NikhilCollooru NikhilCollooru merged commit 56bf5e6 into prestodb:master Feb 26, 2025
54 checks passed
This was referenced Mar 10, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zacw7 zacw7 zacw7 approved these changes

@NikhilCollooru NikhilCollooru NikhilCollooru approved these changes

@xiaoxmeng xiaoxmeng xiaoxmeng left review comments

@presto-oss presto-oss Awaiting requested review from presto-oss presto-oss is a code owner automatically assigned from prestodb/committers

Assignees
No one assigned
Labels
from:Meta PR from Meta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kewang1024 @zacw7 @NikhilCollooru @xiaoxmeng @prestodb-ci