Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GH Actions for doc-only PR #24537

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

yhwang
Copy link
Member

@yhwang yhwang commented Feb 12, 2025

Description

When there is no code change, some steps in the GA workflow are not able to be performed and cause failures. Put the if condition to check the code change in those steps. For non-required tests, use paths-ignore to skip the test directly.

Motivation and Context

fix the GH action error when a PR contains only document changes.
example failures:

Impact

doc-only PR can't be merged and need this fix

Test Plan

verify the doc-only PR after this PR is merged

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== NO RELEASE NOTE ==

@yhwang yhwang requested review from czentgr and a team as code owners February 12, 2025 01:01
@yhwang yhwang requested a review from jaystarshot February 12, 2025 01:01
@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Feb 12, 2025
@prestodb-ci prestodb-ci requested review from a team and jp-sivaprasad and removed request for a team February 12, 2025 01:01
Copy link
Contributor

@czentgr czentgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. General comment.

.github/workflows/arrow-flight-tests.yml Outdated Show resolved Hide resolved
When there is no code change, some steps in the GA workflow can't
run and cause errors. Put the `if condition` to check the code
change in those steps.

Signed-off-by: Yihong Wang <yh.wang@ibm.com>
@yhwang yhwang force-pushed the fix-gh-action-4-doc-only-pr branch from 4a47a34 to a6ea0b4 Compare February 13, 2025 20:43
Copy link
Contributor

@czentgr czentgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Nit: Please update the description to mention that the arrow workflow is excluded from runs for doc-only changes rather than adding the if check as described.

@yhwang
Copy link
Member Author

yhwang commented Feb 13, 2025

updated!

@yhwang yhwang merged commit 089fcf8 into prestodb:master Feb 13, 2025
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
from:IBM PR from IBM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants