Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Join PrestoDB on Slack link on document pages #24534

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yhwang
Copy link
Member

@yhwang yhwang commented Feb 11, 2025

Description

Adding a link in the document pages to encourage users to join the PrestoDB Slack when seeking help.

Motivation and Context

Document pages are where users look for instructions/information when setting up a Presto cluster.
Adding the link to direct users to the Slack channels when encountering any issues would
improve the adoption process.

Impact

No function impact

Test Plan

Generate the doc website and check the new link

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== NO RELEASE NOTE ==

@yhwang yhwang requested review from steveburnett, elharo and a team as code owners February 11, 2025 19:08
@yhwang yhwang requested a review from presto-oss February 11, 2025 19:08
@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Feb 11, 2025
@prestodb-ci prestodb-ci requested review from a team, nishithakbhaskaran and NivinCS and removed request for a team February 11, 2025 19:08
@yhwang
Copy link
Member Author

yhwang commented Feb 11, 2025

highlight the new link in the screenshot below:
Screenshot 2025-02-11 at 11 09 30 AM

and the link goes to: https://communityinviter.com/apps/prestodb/prestodb

Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (docs)

Pull branch, local doc build.

The link for PrestoDB Slack visible in the right column of links.

Screenshot 2025-02-11 at 2 10 45 PM

Clicking the link opens the Community Inviter link for the PrestoDB Slack.

Screenshot 2025-02-11 at 2 10 52 PM

@yhwang
Copy link
Member Author

yhwang commented Feb 11, 2025

@steveburnett not sure why a doc-only PR would trigger those GH actions for code changes. I thought we update GH workflow to handle doc-only PR different.

@steveburnett
Copy link
Contributor

@steveburnett not sure why a doc-only PR would trigger those GH actions for code changes. I thought we update GH workflow to handle doc-only PR different.

I think the doc-only PR workflow may be limited to .rst files not .html, or may not include the /_templates directory.

@yhwang
Copy link
Member Author

yhwang commented Feb 11, 2025

I believe the filter is:

          codechange:
            - '!presto-docs/**'

but seems the GH actions are not stable at this moment. Maybe someone is fixing it now.

Adding a link in the document pages to encourage users to
join the PrestoDB Slack when seeking help.

Signed-off-by: Yihong Wang <yh.wang@ibm.com>
@yhwang yhwang force-pushed the add-join-slack-to-doc branch from 5d50a17 to e7e9b62 Compare February 11, 2025 22:26
@yhwang
Copy link
Member Author

yhwang commented Feb 12, 2025

@steveburnett I believe there is something wrong with the GH workflow. Create a PR to fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
from:IBM PR from IBM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants