[native] Fix 'Number of sorting keys must be greater than zero' #22050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A query with row_number() window function using same partitioning and sorting keys and a limit on row number values used to fail with ``` Caused by: java.lang.RuntimeException: sortingKeys_.size() > 0 (0 vs. 0) Number of sorting keys must be greater than zero ``` This happened because Prestissimo dropped sorting keys from Presto's TopNRowNumberNode and tried to create TopNRowNumberNode in Velox with no sorting keys. The fix is to use Velox's RowNumberNode when all sorting keys are present as partitioning keys.
amitkdutta
approved these changes
Feb 29, 2024
xiaoxmeng
approved these changes
Feb 29, 2024
48 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A query with row_number() window function using same partitioning and sorting
keys and a limit on row number values used to fail with
This happened because Prestissimo dropped sorting keys from Presto's
TopNRowNumberNode and tried to create TopNRowNumberNode in Velox with no
sorting keys. The fix is to use Velox's RowNumberNode when all sorting keys are
present as partitioning keys.