-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[native] Fix 'Number of sorting keys must be greater than zero'
A query with row_number() window function using same partitioning and sorting keys and a limit on row number values used to fail with ``` Caused by: java.lang.RuntimeException: sortingKeys_.size() > 0 (0 vs. 0) Number of sorting keys must be greater than zero ``` This happened because Prestissimo dropped sorting keys from Presto's TopNRowNumberNode and tried to create TopNRowNumberNode in Velox with no sorting keys. The fix is to use Velox's RowNumberNode when all sorting keys are present as partitioning keys.
- Loading branch information
1 parent
61794f0
commit cec0968
Showing
3 changed files
with
17 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters