Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add column comments for iceberg tables #17481

Merged
merged 1 commit into from
Mar 21, 2022
Merged

Add column comments for iceberg tables #17481

merged 1 commit into from
Mar 21, 2022

Conversation

ChunxuTang
Copy link
Member

@ChunxuTang ChunxuTang commented Mar 17, 2022 •
edited
Loading

Add column comments for iceberg tables
Cherry-pick of trinodb/trino@bc61aca

Co-Authored-By: Yuya Ebihara yuya.ebihara@starburstdata.com

== RELEASE NOTES ==

Iceberg Changes
* Store column comments for iceberg tables

@ChunxuTang @ebyhr
Add column comments for Iceberg tables
5571650 
Cherry-pick of trinodb/trino@bc61aca

Co-Authored-By: Yuya Ebihara <yuya.ebihara@starburstdata.com>
@ChunxuTang
Copy link
Member Author

Hi @zhenxiao and @beinan, would you mind having a quick look at this PR? Thanks!

beinan
beinan approved these changes Mar 19, 2022
View reviewed changes
Copy link
Member

@beinan beinan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@beinan
Copy link
Member

beinan commented Mar 19, 2022

no release note for this great feature?

@ChunxuTang
Copy link
Member Author

no release note for this great feature?

@beinan Thanks for your suggestion! Updated the release note of this PR.

@beinan beinan merged commit a64e7a4 into prestodb:master Mar 21, 2022
@mshang816 mshang816 mentioned this pull request May 17, 2022
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beinan beinan beinan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChunxuTang @beinan