Add column comments for Iceberg tables

Cherry-pick of trinodb/trino@bc61aca Co-Authored-By: Yuya Ebihara <yuya.ebihara@starburstdata.com>
prestodb · Mar 17, 2022 · 5571650 · 5571650
1 parent 1820148
commit 5571650
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/presto-iceberg/src/main/java/com/facebook/presto/iceberg/IcebergHadoopMetadata.java b/presto-iceberg/src/main/java/com/facebook/presto/iceberg/IcebergHadoopMetadata.java
@@ -282,7 +282,7 @@ public void addColumn(ConnectorSession session, ConnectorTableHandle tableHandle
     {
         TableIdentifier tableIdentifier = toIcebergTableIdentifier(((IcebergTableHandle) tableHandle).getSchemaTableName());
         Table icebergTable = resourceFactory.getCatalog(session).loadTable(tableIdentifier);
-        icebergTable.updateSchema().addColumn(column.getName(), toIcebergType(column.getType())).commit();
+        icebergTable.updateSchema().addColumn(column.getName(), toIcebergType(column.getType()), column.getComment()).commit();
     }
 
     @Override

diff --git a/presto-iceberg/src/main/java/com/facebook/presto/iceberg/IcebergHiveMetadata.java b/presto-iceberg/src/main/java/com/facebook/presto/iceberg/IcebergHiveMetadata.java
@@ -322,7 +322,7 @@ public void addColumn(ConnectorSession session, ConnectorTableHandle tableHandle
     {
         IcebergTableHandle handle = (IcebergTableHandle) tableHandle;
         org.apache.iceberg.Table icebergTable = getHiveIcebergTable(metastore, hdfsEnvironment, session, handle.getSchemaTableName());
-        icebergTable.updateSchema().addColumn(column.getName(), toIcebergType(column.getType())).commit();
+        icebergTable.updateSchema().addColumn(column.getName(), toIcebergType(column.getType()), column.getComment()).commit();
     }
 
     @Override

diff --git a/presto-iceberg/src/test/java/com/facebook/presto/iceberg/TestAbstractIcebergSmoke.java b/presto-iceberg/src/test/java/com/facebook/presto/iceberg/TestAbstractIcebergSmoke.java
@@ -371,6 +371,11 @@ public void testColumnComments()
         assertQuery(session, "SHOW COLUMNS FROM test_column_comments",
                 "VALUES ('_bigint', 'bigint', '', 'test column comment')");
 
+        assertUpdate("ALTER TABLE test_column_comments ADD COLUMN _varchar VARCHAR COMMENT 'test new column comment'");
+        assertQuery(
+                "SHOW COLUMNS FROM test_column_comments",
+                "VALUES ('_bigint', 'bigint', '', 'test column comment'), ('_varchar', 'varchar', '', 'test new column comment')");
+
         dropTable(session, "test_column_comments");
     }