Add join table reference check in JOIN ON clause #17460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
highker
approved these changes
Mar 11, 2022
Comment on lines
1775
to
1776
| String warningMessage = tableName.isPresent() | ||
| ? |
There was a problem hiding this comment.
put ? to the end of last line
Comment on lines
1782
to
1783
| tableName.get())) | ||
| : |
There was a problem hiding this comment.
put : to the end of the last line
jainxrohit
reviewed
Mar 11, 2022
| rightTableName = ((Table) rightRelation).getName().toString(); | ||
| else if (relation instanceof AliasedRelation) { | ||
| AliasedRelation aliasedRelation = (AliasedRelation) relation; | ||
| if (aliasedRelation.getRelation() instanceof Table) { |
There was a problem hiding this comment.
We can call tryGetTable here on the aliasedRelation.getRelation()?
There was a problem hiding this comment.
I do not see tryGetTable() method anywhere, only tryGetTableName(). And you are pointing to the body of tryGetTableName().
There was a problem hiding this comment.
yeah tryGetTableName, it could have kept the code cleaner. Anyways @highker merged the PR.
Often times, while specifying the joining condition in JOIN ON clause, users make mistakes and not referencing the joining table along side with other table in join condition that result in performance issue due to conditional join resulting in CROSS JOIN. This change will extend the number of cases when user is shown the PERFORMANCE_WARNING when JOIN ON clause misses the comparison expression with joining table and other table. Specifically, it covers the cases when user does not explicitly refer to the relation through table name or alias in JOIN ON clause. Resolves:prestodb#17382 See also: prestodb#17333
b08b8dc to
97db2f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Often times, while specifying the joining condition in JOIN ON clause,
users make mistakes and not referencing the joining table along side
with other table in join condition that result in performance issue due
to conditional join resulting in CROSS JOIN.
This change will extend the number of cases when user is shown the
PERFORMANCE_WARNING when JOIN ON clause misses the comparison expression
with joining table and other table. Specifically, it covers the cases
when user does not explicitly refer to the relation through table name
or alias in JOIN ON clause.
Resolves:#17382
See also: #17333