Add join table reference check in JOIN ON clause #17333

rmarduga · 2022-02-22T21:18:17Z

While it is permitted to omit the reference of the joining table in a conditional join, the result of such join can lead to a cross join with filter, which can harm the query execution performance. Often, such queries are just a result of copy and paste from another join when user updated the joining table name but forgot to update the join condition.

This change will show the PERFORMANCE_WARNING to the user in cases when JOIN ON clause misses the comparison expression with joining table and other table.

== NO RELEASE NOTE ==

linux-foundation-easycla · 2022-02-22T21:18:20Z

The committers are authorized under a signed CLA.

✅ Ruslan Mardugalliamov (6649d94c905415b48e2e269dc03f82f125722051)

presto-main/src/main/java/com/facebook/presto/sql/analyzer/StatementAnalyzer.java

jainxrohit · 2022-02-22T23:57:24Z

Can you please submit a CLA a support request?
https://jira.linuxfoundation.org/servicedesk/customer/portal/4

presto-main/src/main/java/com/facebook/presto/sql/analyzer/StatementAnalyzer.java

jainxrohit · 2022-02-24T16:45:52Z

@rmarduga Can you please squash both commits to a single commit?

jainxrohit · 2022-02-24T22:04:06Z

le it is permitted to omit the reference of the joining table in a conditional join, the result of such join can lead to a cross join with filter, which can harm the query execution performance. Often, such queries are just a result of copy and paste from another join when user updated the joining table name but forgot to update the join condition.

This change will show the PERFORMANCE_WARNING to the user in cases when JOIN ON clause misses the comparison expression with joining table and other table.

Test plan - mvn clean install -DskipTests -T1C

You can get rid of line break in the PR description. No need for
"Test plan - mvn clean install -DskipTests -T1C"

presto-main/src/test/java/com/facebook/presto/sql/analyzer/TestAnalyzer.java

presto-main/src/main/java/com/facebook/presto/sql/analyzer/StatementAnalyzer.java

While it is permitted to omit the reference of the joining table in a conditional join, the result of such join can lead to a cross join with filter, which can harm the query execution performance. Often, such queries are just a result of copy and paste from another join when user updated the joining table name but forgot to update the join condition. This change will show the PERFORMANCE_WARNING to the user in cases when JOIN ON clause misses the comparison expression with joining table and other table.

Often times, while specifying the joining condition in JOIN ON clause, users make mistakes and not referencing the joining table along side with other table in join condition that result in performance issue due to conditional join resulting in CROSS JOIN. This change will extend the number of cases when user is shown the PERFORMANCE_WARNING when JOIN ON clause misses the comparison expression with joining table and other table. Specifically, it covers the cases when user does not explicitly refer to the relation through table name or alias in JOIN ON clause. Resolves:prestodb#17382 See also: prestodb#17333

Often times, while specifying the joining condition in JOIN ON clause, users make mistakes and not referencing the joining table along side with other table in join condition that result in performance issue due to conditional join resulting in CROSS JOIN. This change will extend the number of cases when user is shown the PERFORMANCE_WARNING when JOIN ON clause misses the comparison expression with joining table and other table. Specifically, it covers the cases when user does not explicitly refer to the relation through table name or alias in JOIN ON clause. Resolves:#17382 See also: #17333

Often times, while specifying the joining condition in JOIN ON clause, users make mistakes and not referencing the joining table along side with other table in join condition that result in performance issue due to conditional join resulting in CROSS JOIN. This change will reduce the number of cases when user is shown the PERFORMANCE_WARNING when JOIN ON clause is actually correct. See also: prestodb#17333, prestodb#17640

Often times, while specifying the joining condition in JOIN ON clause, users make mistakes and not referencing the joining table along side with other table in join condition that result in performance issue due to conditional join resulting in CROSS JOIN. This change will reduce the number of cases when user is shown the PERFORMANCE_WARNING when JOIN ON clause is actually correct. See also: #17333, #17640

Often times, while specifying the joining condition in JOIN ON clause, users make mistakes and not referencing the joining table along side with other table in join condition that result in performance issue due to conditional join resulting in CROSS JOIN. This change will reduce the number of cases when user is shown the PERFORMANCE_WARNING when JOIN ON clause is actually correct. See also: prestodb#17333, prestodb#17640

jainxrohit requested review from kaikalur and jainxrohit February 22, 2022 21:29

kaikalur requested changes Feb 22, 2022

View reviewed changes

presto-main/src/main/java/com/facebook/presto/sql/analyzer/StatementAnalyzer.java Outdated Show resolved Hide resolved

presto-main/src/main/java/com/facebook/presto/sql/analyzer/StatementAnalyzer.java Show resolved Hide resolved

kaikalur requested changes Feb 23, 2022

View reviewed changes