-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show warning if no token is provided on a Github repo #72
Show warning if no token is provided on a Github repo #72
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for preparing this PR!
I have several code quality comments, after which we are ready to ship this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes. It's a lot simpler now.
I have one minor comment regarding readability & one major one regarding making this feature compatible with Windows.
After those are done, we are ready to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thanks for taking the time to get this through.
Merging it to master.
No, no. Thanks for working with me on it!! |
This PR closes #63 by printing an error (in red) if the user is accessing a Github repo without an API token! I tried to make things pretty explicit so it's easier to reason about but let me know what you think!