Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show a warning if no apitoken is specified for any github repository #63

Closed
preslavmihaylov opened this issue Sep 13, 2020 · 2 comments · Fixed by #72
Closed

Show a warning if no apitoken is specified for any github repository #63

preslavmihaylov opened this issue Sep 13, 2020 · 2 comments · Fixed by #72
Labels
enhancement New feature or request UX

Comments

@preslavmihaylov
Copy link
Owner

Github has a rate limit in-place for unauthenticated requests to their API which is 60 requests per hour.

For any production usage, this is a very low quota.
However, if the requests are authenticated (even if accessing public repositories), the quota is 5000 requests per hour, which should suffice for most use cases.

Therefore, a warning should be shown if the configuration lacks an apitoken for github repositories, regardless of whether the repository is private or not.

In scope of this issue is to include this warning in the README for public github repository setup as well.

You can reuse the mechanics of #62 for showing this warning.

@preslavmihaylov preslavmihaylov added enhancement New feature or request UX labels Sep 13, 2020
@codykaup
Copy link
Contributor

codykaup commented Oct 6, 2020

I'd like to snag this one as well if it's still available!

@preslavmihaylov
Copy link
Owner Author

@codykaup go ahead!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request UX
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants