Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(query): support multiple field cursors - @rscotten #268

Merged
merged 5 commits into from
Feb 25, 2020
Merged

feat(query): support multiple field cursors - @rscotten #268

merged 5 commits into from
Feb 25, 2020

Conversation

rscotten
Copy link
Contributor

@rscotten rscotten commented Feb 23, 2020 •
edited
Loading

Description

Firestore allows for multiple fields to be used as query cursors, but the current Firestore query builder in query.js only allows for one field.

This PR changes query.js to allow for multiple cursor fields, and adds the relevant tests.

It also fixes some typos and adds missing assertions in query.spec.js.

In saving the changes to the README.md, Prettier changed the whitespace and added semicolons. If this is undesired, I can revert.

Check List

If not relevant to pull request, check off as complete

  • All tests passing
  • Docs updated with any changes or examples if applicable
  • Added tests to ensure new feature(s) work properly

Relevant Issues

#65 added the cursors to the query builder, but didn't support multiple fields

@prescottprue
Copy link
Owner

Awesome work, thanks for the PR! I'll try to review this today

@prescottprue prescottprue changed the base branch from master to v0.13.0 February 25, 2020 01:25
@prescottprue prescottprue changed the title Support multiple field cursors feat(query): support multiple field cursors - @rscotten Feb 25, 2020
@prescottprue prescottprue merged commit 60ab8f0 into prescottprue:v0.13.0 Feb 25, 2020
@rscotten rscotten deleted the fix-multiple-field-cursors branch February 25, 2020 02:54
@rscotten rscotten restored the fix-multiple-field-cursors branch February 25, 2020 02:55
@rscotten
Copy link
Contributor Author

@prescottprue Thanks for the merge! :)

@rscotten
Copy link
Contributor Author

@prescottprue Once v0.13.0 gets released, I'll submit a PR for updated types for react-redux-firebase

@prescottprue prescottprue mentioned this pull request Feb 26, 2020
Merged
3 tasks
prescottprue added a commit that referenced this pull request Feb 27, 2020
@prescottprue @rscotten @dependabot
v0.13.0 (#270)
0ee3bc5 
* feat(query): support multiple field cursors - @rscotten (#268)
* build(deps-dev): bump codecov from 3.6.4 to 3.6.5 (#267)

Co-authored-by: Richard Scotten <rscotten@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prescottprue prescottprue Awaiting requested review from prescottprue

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rscotten @prescottprue