-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runs npm run build
after installation
#1
Comments
Shouldnt we just build it first and then distribute the code? Is this something we are doing to increase compatibility? Because it seems to be decreasing compatibility in my case. Because in order to be able to build the library, it seems that we need to have the Even when you install the cross-env script, building fails with the following error:
So I suggest that we build first and then distribute the library, because all these dependencies that are required to be able to build the library seem to be getting in the way. What do you think @prescottprue? |
The issue was partially solved in the latest push. |
…s logic - @alexmattson The logic for `oneListenerPerPath: true` and `allowMultipleListeners: false` greatly overlapped. This PR removes the `oneListenerPerPath` config option and instead opts to standardize that functionality as the default. Now whenever you call the setListeners/unsetListeners it will track the number of listeners set up. Also gives the opt out with `allowMultipleListeners: true` Changes: 1) Updated `setListeners` and `unsetListeners` functions 2) Changed `oneListenerPerPath` tests to `allowMultipleListeners` tests 3) removed `oneListenerPerPath` from docs ### Check List If not relevant to pull request, check off as complete - [x] All tests passing - [x] Docs updated with any changes or examples if applicable - [x] Added tests to ensure new feature(s) work properly ### Relevant Issues <!-- * #1 -->
For some reason, installing
redux-firestore
will runnpm run build
immediately after installation. That results in the failure of the installation. I was trying to install it in a create-react-app project, and there was already a build script in my package.json. I temporarily removed that script from my package.json, and the install was successful. So I think that there's some sort of interference between the build script thatredux-firestore
calls, and the one that exists in the root project's package.json.The text was updated successfully, but these errors were encountered: