Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runs npm run build after installation #1

Closed
mechanical-turk opened this issue Oct 5, 2017 · 2 comments
Closed

runs npm run build after installation #1

mechanical-turk opened this issue Oct 5, 2017 · 2 comments

Comments

@mechanical-turk
Copy link

For some reason, installing redux-firestore will run npm run build immediately after installation. That results in the failure of the installation. I was trying to install it in a create-react-app project, and there was already a build script in my package.json. I temporarily removed that script from my package.json, and the install was successful. So I think that there's some sort of interference between the build script that redux-firestore calls, and the one that exists in the root project's package.json.

@mechanical-turk
Copy link
Author

Shouldnt we just build it first and then distribute the code? Is this something we are doing to increase compatibility? Because it seems to be decreasing compatibility in my case. Because in order to be able to build the library, it seems that we need to have the cross-env script installed globally.

Even when you install the cross-env script, building fails with the following error:

Error: spawn babel ENOENT
    at exports._errnoException (util.js:1016:11)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:189:19)
    at onErrorNT (internal/child_process.js:366:16)
    at _combinedTickCallback (internal/process/next_tick.js:102:11)
    at process._tickCallback (internal/process/next_tick.js:161:9)
    at Function.Module.runMain (module.js:607:11)
    at startup (bootstrap_node.js:158:16)
    at bootstrap_node.js:575:3

So I suggest that we build first and then distribute the library, because all these dependencies that are required to be able to build the library seem to be getting in the way. What do you think @prescottprue?

@mechanical-turk
Copy link
Author

The issue was partially solved in the latest push.

prescottprue added a commit that referenced this issue Nov 8, 2018
…s logic - @alexmattson

The logic for `oneListenerPerPath: true` and `allowMultipleListeners: false` greatly overlapped. This PR removes the `oneListenerPerPath` config option and instead opts to standardize that functionality as the default. Now whenever you call the setListeners/unsetListeners it will track the number of listeners set up. Also gives the opt out with `allowMultipleListeners: true`

Changes:

1) Updated `setListeners` and `unsetListeners` functions 
2) Changed `oneListenerPerPath` tests to `allowMultipleListeners` tests
3) removed `oneListenerPerPath` from docs


### Check List
If not relevant to pull request, check off as complete

- [x] All tests passing
- [x] Docs updated with any changes or examples if applicable
- [x] Added tests to ensure new feature(s) work properly

### Relevant Issues
<!-- * #1 -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant