Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update userId.md - CNVR source #1656

Merged
merged 1 commit into from
Dec 11, 2019
Merged

Update userId.md - CNVR source #1656

merged 1 commit into from
Dec 11, 2019

Conversation

CNVR-SamA
Copy link
Contributor

Source is supposed to be a domain in 3.0 ORTB spec

Source is supposed to be a domain in 3.0 ORTB spec
@bretg
Copy link
Contributor

bretg commented Dec 8, 2019

there's no such domain as pubcid.org.

$ host pubcid.org
Host pubcid.org not found: 3(NXDOMAIN)

@pycnvr ?

@bretg bretg added the question label Dec 8, 2019
@pycnvr
Copy link
Contributor

pycnvr commented Dec 9, 2019

@bretg Yeah It is already registered by Conversant partly for this reason. The site should have more info in the future. Please see icann for registration.

https://lookup.icann.org/

@bretg bretg added LGTM and removed question labels Dec 9, 2019
@bretg
Copy link
Contributor

bretg commented Dec 9, 2019

Ok. You're going to need to make this change in the code too -- https://github.com/prebid/Prebid.js/edit/master/modules/prebidServerBidAdapter/index.js line 724.

Please mention this docs PR in the code PR and I'll help push both along

@pycnvr
Copy link
Contributor

pycnvr commented Dec 9, 2019

Sounds good. Thanks.

@pycnvr
Copy link
Contributor

pycnvr commented Dec 9, 2019

prebid/Prebid.js#4561

@bretg bretg merged commit 6158fa6 into prebid:master Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants