Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use 'pubcid.org' as the source for pubcid in extended IDs #4561

Merged
merged 1 commit into from
Dec 10, 2019
Merged

Use 'pubcid.org' as the source for pubcid in extended IDs #4561

merged 1 commit into from
Dec 10, 2019

Conversation

pycnvr
Copy link
Collaborator

@pycnvr pycnvr commented Dec 9, 2019

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Change the source of pubcid from 'pubcommon' to 'pubcid.org' when extended ID is used

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@pycnvr pycnvr mentioned this pull request Dec 9, 2019
Merged
@bretg bretg requested a review from sumit116 December 9, 2019 21:02
@bretg bretg added the needs 2nd review Core module updates require two approvals from the core team label Dec 9, 2019
@bretg bretg removed the request for review from sumit116 December 10, 2019 15:44
mkendall07
mkendall07 approved these changes Dec 10, 2019
View reviewed changes
Copy link
Member

@mkendall07 mkendall07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkendall07 mkendall07 merged commit 5b57f48 into prebid:master Dec 10, 2019
@pycnvr pycnvr deleted the pubcid_org_as_source branch December 10, 2019 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkendall07 mkendall07 mkendall07 approved these changes

@bretg bretg bretg approved these changes

Assignees
No one assigned
Labels
needs 2nd review Core module updates require two approvals from the core team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pycnvr @mkendall07 @bretg @sumit116