-
Notifications
You must be signed in to change notification settings - Fork 769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Adapter: TrafficGate #2226
New Adapter: TrafficGate #2226
Conversation
Hello. Link for docs pull request: prebid/prebid.github.io#3711 |
Hello. Can you approve it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and I'm close to approving. Just left two minor comments.
adapters/trafficgate/trafficgatetest/supplemental/bad_host.json
Outdated
Show resolved
Hide resolved
adapters/trafficgate/trafficgatetest/supplemental/bad_placementid.json
Outdated
Show resolved
Hide resolved
adapters/trafficgate/trafficgatetest/exemplary/multiple-imps.json
Outdated
Show resolved
Hide resolved
adapters/trafficgate/trafficgatetest/supplemental/bad-imp-ext.json
Outdated
Show resolved
Hide resolved
Hi @vlaktion, could you also provide us with a valid subdomain so we can test this out manually? Thanks in advance. |
Hi @vlaktion, just a friendly reminder to provide a valid subdomain when you get a minute so we can test this out manually. |
Hello. Yes, we have test environment. You need send parameter "placementId": "0" it will give test response. vudha.bc-plugin.com it is one of our partners. Example: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thank you for providing the sample endpoint and request. I have just a few nitpicks before we merge in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: vlad <vlaktionov@decenterads.com>
Co-authored-by: vlad <vlaktionov@decenterads.com>
No description provided.