Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Adapter: TrafficGate #2226

Merged
merged 7 commits into from
May 25, 2022
Merged

New Adapter: TrafficGate #2226

merged 7 commits into from
May 25, 2022

Conversation

vlaktion
Copy link
Contributor

No description provided.

@vlaktion
Copy link
Contributor Author

Hello. Link for docs pull request: prebid/prebid.github.io#3711

@mansinahar mansinahar changed the title Add new Adapter: TrafficGate New Adapter: TrafficGate Apr 19, 2022
@mansinahar mansinahar requested a review from AlexBVolcy April 19, 2022 17:45
@mansinahar mansinahar requested a review from bsardo April 19, 2022 17:46
adapters/trafficgate/trafficgate.go Outdated Show resolved Hide resolved
adapters/trafficgate/trafficgate.go Outdated Show resolved Hide resolved
adapters/trafficgate/trafficgate.go Outdated Show resolved Hide resolved
adapters/trafficgate/trafficgate.go Outdated Show resolved Hide resolved
adapters/trafficgate/trafficgate.go Show resolved Hide resolved
config/config.go Outdated Show resolved Hide resolved
@vlaktion
Copy link
Contributor Author

Hello. Can you approve it?

Copy link
Contributor

@AlexBVolcy AlexBVolcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and I'm close to approving. Just left two minor comments.

adapters/trafficgate/trafficgate.go Outdated Show resolved Hide resolved
adapters/trafficgate/trafficgate.go Outdated Show resolved Hide resolved
@bsardo
Copy link
Collaborator

bsardo commented May 9, 2022

Hi @vlaktion, could you also provide us with a valid subdomain so we can test this out manually? Thanks in advance.

@bsardo
Copy link
Collaborator

bsardo commented May 11, 2022

Hi @vlaktion, just a friendly reminder to provide a valid subdomain when you get a minute so we can test this out manually.

@vlaktion
Copy link
Contributor Author

Hello. Yes, we have test environment. You need send parameter "placementId": "0" it will give test response. vudha.bc-plugin.com it is one of our partners. Example:
URL:
http://vudha.bc-plugin.com/?c=o&m=rtb
Body:
{
"id": "test-request-id",
"device": {
"ip": "123.123.123.123",
"ifa": "zxcjbzxmc-zxcbmz-zxbcz-zxczx"
},
"app": {
"id": "1",
"bundle": "com.wls.testwlsapplication"
},
"imp": [
{
"id": "test-imp-id3",
"video": {
"mimes": ["video/mp4"],
"protocols": [2, 5],
"w": 1024,
"h": 576
},
"ext": {
"bidder": {
"placementId": "0",
"host": "vudha"
}
}
}
]
}

AlexBVolcy
AlexBVolcy previously approved these changes May 23, 2022
Copy link
Contributor

@SyntaxNode SyntaxNode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you for providing the sample endpoint and request. I have just a few nitpicks before we merge in.

adapters/trafficgate/trafficgate.go Outdated Show resolved Hide resolved
adapters/trafficgate/trafficgate.go Show resolved Hide resolved
adapters/trafficgate/trafficgate.go Show resolved Hide resolved
adapters/trafficgate/trafficgate.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@bsardo bsardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bsardo bsardo merged commit 4a2d25d into prebid:master May 25, 2022
jorgeluisrocha pushed a commit to jwplayer/prebid-server that referenced this pull request Sep 28, 2022
Co-authored-by: vlad <vlaktionov@decenterads.com>
shunj-nb pushed a commit to ParticleMedia/prebid-server that referenced this pull request Nov 8, 2022
Co-authored-by: vlad <vlaktionov@decenterads.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants