-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TrafficGate Bid Adapter: add new bid adapter #8328
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @vlaktion,
I tried to test the example that you gave in your md file, but I didn't get any bid response back. Can you please provide a working example?
modules/trafficgateBidAdapter.js
Outdated
import { BANNER, NATIVE, VIDEO } from '../src/mediaTypes.js'; | ||
|
||
const BIDDER_CODE = 'trafficgate'; | ||
const URL = '//[HOST].bc-plugin.com/?c=o&m=multi'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please hardcode this to https?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello. What if site use http only? It will error 'https request over http'?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my experience, sending request to secure endpoints from http webpages doesn't cause any issue. You can test it out locally if you want, I ran the hello world page with a local web server running http, and it did made the request to the secure appnexus endpoint.
Also, I see that the endpoint doesn't have a fixed host. Is there any specific reason to have a "variable" host name?
Hello. Yes, we have test environment. You need send parameter "placementId": 0, it will give test response. vudha.bc-plugin.com it is one of our partners. Example: |
Sorry, I tried to click the url: https://vudha.bc-plugin.com/?c=o&m=multi, but it's not working. Is there any other way for me to test this adapter? |
@Fawke Hi. Did you send a POST query? |
Hi @vlaktion, Can you please hardcode your endpoint url to |
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* TrafficGate Bid Adapter: add new bid adapter * TrafficGate Bid Adapter: add new bid adapter * set to https * set to https Co-authored-by: vlad <vlaktionov@decenterads.com>
* TrafficGate Bid Adapter: add new bid adapter * TrafficGate Bid Adapter: add new bid adapter * set to https * set to https Co-authored-by: vlad <vlaktionov@decenterads.com>
Type of change
Description of change
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information