Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TrafficGate Bid Adapter: add new bid adapter #8328

Merged
merged 4 commits into from
Jun 10, 2022
Merged

Conversation

vlaktion
Copy link
Contributor

@vlaktion vlaktion commented Apr 27, 2022

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@vlaktion
Copy link
Contributor Author

@vlaktion
Copy link
Contributor Author

Copy link
Contributor

@Fawke Fawke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vlaktion,

I tried to test the example that you gave in your md file, but I didn't get any bid response back. Can you please provide a working example?

import { BANNER, NATIVE, VIDEO } from '../src/mediaTypes.js';

const BIDDER_CODE = 'trafficgate';
const URL = '//[HOST].bc-plugin.com/?c=o&m=multi';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please hardcode this to https?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello. What if site use http only? It will error 'https request over http'?

Copy link
Contributor

@Fawke Fawke May 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my experience, sending request to secure endpoints from http webpages doesn't cause any issue. You can test it out locally if you want, I ran the hello world page with a local web server running http, and it did made the request to the secure appnexus endpoint.

Also, I see that the endpoint doesn't have a fixed host. Is there any specific reason to have a "variable" host name?

@vlaktion
Copy link
Contributor Author

Hello. Yes, we have test environment. You need send parameter "placementId": 0, it will give test response. vudha.bc-plugin.com it is one of our partners. Example:
URL:
https://vudha.bc-plugin.com/?c=o&m=multi
Body:
{
"bidId": "9ec5b177515ee2e5",
"bidder": "trafficgate",
"language": "en-EN",
"secure": 1,
"host": "example.com",
"page": "/page",
"placements": [{
"placementId": 0,
"bidId": "9ec5b177515ee2e5",
"traffic": "video"
}]
}

@Fawke
Copy link
Contributor

Fawke commented May 24, 2022

Hello. Yes, we have test environment. You need send parameter "placementId": 0, it will give test response. vudha.bc-plugin.com it is one of our partners. Example: URL: https://vudha.bc-plugin.com/?c=o&m=multi Body: { "bidId": "9ec5b177515ee2e5", "bidder": "trafficgate", "language": "en-EN", "secure": 1, "host": "example.com", "page": "/page", "placements": [{ "placementId": 0, "bidId": "9ec5b177515ee2e5", "traffic": "video" }] }

Sorry, I tried to click the url: https://vudha.bc-plugin.com/?c=o&m=multi, but it's not working. Is there any other way for me to test this adapter?

@vlaktion
Copy link
Contributor Author

vlaktion commented Jun 3, 2022

@Fawke Hi. Did you send a POST query?
Screenshot 2022-06-03 at 11 08 37

@Fawke
Copy link
Contributor

Fawke commented Jun 8, 2022

Hi @vlaktion,

Can you please hardcode your endpoint url to https? Everything else looks good.

@vlaktion
Copy link
Contributor Author

vlaktion commented Jun 8, 2022

Done

Copy link
Contributor

@Fawke Fawke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Fawke Fawke merged commit 6d66da7 into prebid:master Jun 10, 2022
renebaudisch pushed a commit to renebaudisch/Prebid.js that referenced this pull request Jun 28, 2022
* TrafficGate Bid Adapter: add new bid adapter

* TrafficGate Bid Adapter: add new bid adapter

* set to https

* set to https

Co-authored-by: vlad <vlaktionov@decenterads.com>
bwhisp pushed a commit to bwhisp/Prebid.js that referenced this pull request Jul 13, 2022
* TrafficGate Bid Adapter: add new bid adapter

* TrafficGate Bid Adapter: add new bid adapter

* set to https

* set to https

Co-authored-by: vlad <vlaktionov@decenterads.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants