Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pubCommonIdSystem.js #5974

Merged
merged 7 commits into from
Nov 15, 2020
Merged

Update pubCommonIdSystem.js #5974

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
548866c
Update pubCommonIdSystem.js
jdwieland8282 Nov 13, 2020
7a3ad1f
Update pubCommonIdSystem.js
jdwieland8282 Nov 13, 2020
814dcc2
Update pubCommonIdSystem.js
jdwieland8282 Nov 13, 2020
9e8b768
Update pubCommonIdSystem.js
jdwieland8282 Nov 13, 2020
e405814
Update pubCommonIdSystem.js
jdwieland8282 Nov 13, 2020
50755fa
Update pubCommonIdSystem.js
jdwieland8282 Nov 13, 2020
1de988d
Update pubCommonIdSystem.js
jdwieland8282 Nov 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions modules/pubCommonIdSystem.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@ const SHAREDID_URL = 'https://id.sharedid.org/id';
const SHAREDID_SUFFIX = '_sharedid';
const EXPIRED_COOKIE_DATE = 'Thu, 01 Jan 1970 00:00:01 GMT';
const SHAREDID_DEFAULT_STATE = false;
const GLVID = 887;
const GVLID = 887;

const storage = getStorageManager(GLVID, 'pubCommonId');
const storage = getStorageManager(GVLID, 'pubCommonId');

/**
* Store sharedid in either cookie or local storage
Expand Down Expand Up @@ -160,7 +160,11 @@ export const pubCommonIdSubmodule = {
* @type {string}
*/
name: MODULE_NAME,

/**
* Vendor id of prebid
* @type {Number}
*/
gvlid: GVLID,
/**
* Return a callback function that calls the pixelUrl with id as a query parameter
* @param pixelUrl
Expand Down