Update pubCommonIdSystem.js #5974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding GVLID to pubCommonIdSubmodule definition
adding GVLID to pubCommonIdSubmodule definition
removing duplicate reference to GVLID in pubCommonIdSubmodule defintion
smenzer
reviewed
Nov 13, 2020
smenzer
requested changes
Nov 13, 2020
fixing typo on ln 23 GLVID --> GVLID
smenzer
reviewed
Nov 13, 2020
modules/pubCommonIdSystem.js
Outdated
| @@ -20,7 +20,7 @@ const SHAREDID_URL = 'https://id.sharedid.org/id'; | |||
| const SHAREDID_SUFFIX = '_sharedid'; | |||
| const EXPIRED_COOKIE_DATE = 'Thu, 01 Jan 1970 00:00:01 GMT'; | |||
| const SHAREDID_DEFAULT_STATE = false; | |||
| const GLVID = 887; | |||
| const GVLID = 887; | |||
|
|
|||
| const storage = getStorageManager(GLVID, 'pubCommonId'); | |||
There was a problem hiding this comment.
looks like there's another typo here
There was a problem hiding this comment.
thanks scott I'm doing to many things at once.
fixing typos,
removing trailing white space
removing trailing white space
smenzer
approved these changes
Nov 15, 2020
stsepelin
pushed a commit
to cointraffic/Prebid.js
that referenced
this pull request
May 28, 2021
* Update pubCommonIdSystem.js adding GVLID to pubCommonIdSubmodule definition * Update pubCommonIdSystem.js adding GVLID to pubCommonIdSubmodule definition * Update pubCommonIdSystem.js removing duplicate reference to GVLID in pubCommonIdSubmodule defintion * Update pubCommonIdSystem.js fixing typo on ln 23 GLVID --> GVLID * Update pubCommonIdSystem.js fixing typos, * Update pubCommonIdSystem.js removing trailing white space * Update pubCommonIdSystem.js removing trailing white space
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding GVLID to pubCommonIdSubmodule definition
Type of change
Description of change
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information