drop specific code for index adapter #1487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
protonate
suggested changes
Aug 14, 2017
| @@ -46,33 +46,18 @@ function getBidders(bid) { | |||
| function bidsBackAdUnit(adUnitCode) { | |||
| const requested = $$PREBID_GLOBAL$$._bidsRequested | |||
| .map(request => request.bids | |||
| .filter(adUnitsFilter.bind(this, $$PREBID_GLOBAL$$._adUnitCodes)) | |||
There was a problem hiding this comment.
I think the above line needs to remain in for now -- not related to index bid counting.
There was a problem hiding this comment.
shouldn't the line below take care of filtering? I don't understand the need for the double filter.
i.e adUnitCode is a subset of ._adUnitCodes
There was a problem hiding this comment.
This is the adUnitsFilter function:
export function adUnitsFilter(filter, bid) {
return filter.includes((bid && bid.placementCode) || (bid && bid.adUnitCode));
}
so while it does behave somewhat differently by testing for placementCode and adUnitCode your right that the next filter cuts that down to just placementCode. Ok, makes sense.
protonate
approved these changes
Aug 14, 2017
mkendall07
added a commit
that referenced
this pull request
Aug 24, 2017
This reverts commit d3cd291.
mkendall07
pushed a commit
that referenced
this pull request
Aug 24, 2017
outoftime
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Aug 24, 2017
…built * 'master' of https://github.com/prebid/Prebid.js: (83 commits) feat(strAdapt): check if tagJS is already present (prebid#1500) Updated karma-mocha, and simplified the test framework for runs which dont include --watch. (prebid#1520) Revert "drop specific code for index adapter (prebid#1487)" (prebid#1529) Override default asset params when set on ad unit (prebid#1524) Adding new kv to xhb Adapter (prebid#1513) removing for...of loops because IE cannot handle them properly (prebid#1523) Increment pre version Prebid 0.27.0 Release Move unit test file to appropriate location (prebid#1516) Support 'cta' native asset (prebid#1505) Add adapter parameter types (prebid#1504) Register bid adapter (prebid#1514) Match port when testing legacy browser (prebid#1511) modify 'featureforward' adapter to be an indepandant adapter (prebid#1288) Feature/s2s client side fallback (prebid#1485) Make bid.vastUrl use the cache URL if the bid didnt already have one. (prebid#1506) OpenX Adapter Update: (prebid#1438) Add session id feature for roxot analytics adapter (prebid#1498) Update platformioBidAdapter (prebid#1493) Adding VAST Payload support for video bids (prebid#1407) ...
ptomasroos
pushed a commit
to happypancake/Prebid.js
that referenced
this pull request
Aug 25, 2017
) This reverts commit d3cd291.
philipwatson
pushed a commit
to mbrtargeting/Prebid.js
that referenced
this pull request
Sep 18, 2017
philipwatson
pushed a commit
to mbrtargeting/Prebid.js
that referenced
this pull request
Sep 18, 2017
) This reverts commit d3cd291.
vzhukovsky
added a commit
to aol/Prebid.js
that referenced
this pull request
Oct 3, 2017
…rebid-official-0.27.1 to release/1.27.0 * commit 'ed7a85baafff3cade5fc05df1cd2bbadca782463': (98 commits) Added compatibility with 0.27.1 for Komoona adapter. Added aol partners ids. Added changelog entry. Fixed minor eslint issues. Fixed failing prebid-cache unit test. Prebid 0.27.1 Release use utils.getTopWindowUrl() to get top window URL for indexexchange a… (prebid#1507) fix prebid#1509 - utils.getTopWindowLocation() returns exception object (prebid#1530) feat(strAdapt): check if tagJS is already present (prebid#1500) Updated karma-mocha, and simplified the test framework for runs which dont include --watch. (prebid#1520) Revert "drop specific code for index adapter (prebid#1487)" (prebid#1529) Override default asset params when set on ad unit (prebid#1524) Adding new kv to xhb Adapter (prebid#1513) removing for...of loops because IE cannot handle them properly (prebid#1523) Increment pre version Prebid 0.27.0 Release Move unit test file to appropriate location (prebid#1516) Support 'cta' native asset (prebid#1505) Add adapter parameter types (prebid#1504) Register bid adapter (prebid#1514) ...
vzhukovsky
added a commit
to aol/Prebid.js
that referenced
this pull request
Oct 3, 2017
….27.0 to aolgithub-master * commit '5c33711e8d9e543b4a1da00563d78f6d0abd1179': (99 commits) Added compatibility with 0.27.1 for Komoona adapter. Added aol partners ids. Added changelog entry. Fixed minor eslint issues. Fixed failing prebid-cache unit test. Updated Komoona bid adapter. Prebid 0.27.1 Release use utils.getTopWindowUrl() to get top window URL for indexexchange a… (prebid#1507) fix prebid#1509 - utils.getTopWindowLocation() returns exception object (prebid#1530) feat(strAdapt): check if tagJS is already present (prebid#1500) Updated karma-mocha, and simplified the test framework for runs which dont include --watch. (prebid#1520) Revert "drop specific code for index adapter (prebid#1487)" (prebid#1529) Override default asset params when set on ad unit (prebid#1524) Adding new kv to xhb Adapter (prebid#1513) removing for...of loops because IE cannot handle them properly (prebid#1523) Increment pre version Prebid 0.27.0 Release Move unit test file to appropriate location (prebid#1516) Support 'cta' native asset (prebid#1505) Add adapter parameter types (prebid#1504) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Resolves #1341
Other information