-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
utils.getTopWindowLocation() returns exception object when Prebid is loaded in an unfriendly iframe #1509
Comments
mkendall07
added a commit
that referenced
this issue
Aug 24, 2017
8 tasks
ptomasroos
pushed a commit
to happypancake/Prebid.js
that referenced
this issue
Aug 25, 2017
philipwatson
pushed a commit
to mbrtargeting/Prebid.js
that referenced
this issue
Sep 18, 2017
jbAdyoulike
pushed a commit
to jbAdyoulike/Prebid.js
that referenced
this issue
Sep 21, 2017
vzhukovsky
added a commit
to aol/Prebid.js
that referenced
this issue
Oct 3, 2017
…rebid-official-0.27.1 to release/1.27.0 * commit 'ed7a85baafff3cade5fc05df1cd2bbadca782463': (98 commits) Added compatibility with 0.27.1 for Komoona adapter. Added aol partners ids. Added changelog entry. Fixed minor eslint issues. Fixed failing prebid-cache unit test. Prebid 0.27.1 Release use utils.getTopWindowUrl() to get top window URL for indexexchange a… (prebid#1507) fix prebid#1509 - utils.getTopWindowLocation() returns exception object (prebid#1530) feat(strAdapt): check if tagJS is already present (prebid#1500) Updated karma-mocha, and simplified the test framework for runs which dont include --watch. (prebid#1520) Revert "drop specific code for index adapter (prebid#1487)" (prebid#1529) Override default asset params when set on ad unit (prebid#1524) Adding new kv to xhb Adapter (prebid#1513) removing for...of loops because IE cannot handle them properly (prebid#1523) Increment pre version Prebid 0.27.0 Release Move unit test file to appropriate location (prebid#1516) Support 'cta' native asset (prebid#1505) Add adapter parameter types (prebid#1504) Register bid adapter (prebid#1514) ...
vzhukovsky
added a commit
to aol/Prebid.js
that referenced
this issue
Oct 3, 2017
….27.0 to aolgithub-master * commit '5c33711e8d9e543b4a1da00563d78f6d0abd1179': (99 commits) Added compatibility with 0.27.1 for Komoona adapter. Added aol partners ids. Added changelog entry. Fixed minor eslint issues. Fixed failing prebid-cache unit test. Updated Komoona bid adapter. Prebid 0.27.1 Release use utils.getTopWindowUrl() to get top window URL for indexexchange a… (prebid#1507) fix prebid#1509 - utils.getTopWindowLocation() returns exception object (prebid#1530) feat(strAdapt): check if tagJS is already present (prebid#1500) Updated karma-mocha, and simplified the test framework for runs which dont include --watch. (prebid#1520) Revert "drop specific code for index adapter (prebid#1487)" (prebid#1529) Override default asset params when set on ad unit (prebid#1524) Adding new kv to xhb Adapter (prebid#1513) removing for...of loops because IE cannot handle them properly (prebid#1523) Increment pre version Prebid 0.27.0 Release Move unit test file to appropriate location (prebid#1516) Support 'cta' native asset (prebid#1505) Add adapter parameter types (prebid#1504) ...
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this issue
Jul 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Type of issue
Bug
Description
When Prebid is loaded in an unfriendly iframe,
utils.getTopWindowLocation()
function is expected return a window object; however, the function returns an exception object instead.Steps to reproduce
Load an iframe that its source contains a secure domain onto an insecure page. Prebid is loaded inside the secure iframe.
Example of exception thrown when

utils.getTopWindowLocation().protocol
is called:Expected results
utils.getTopWindowLocation()
should return the top-most window that it can possibly reach. In the above scenario from "Steps to reproduce" section, the function should return the iframe window because the iframe does now have access to its parent due to the cross-origin issue. At the very least,utils.getTopWindowLocation()
should return the current window when it fails to getwindow.top.location
object.Actual results
utils.getTopWindowLocation()
returns an exception object. This object throws an exception when used:As a result of this issue, adapters that relies on this function to get the top most window do not participate in auction.
Platform details
Chrome Version 59.0.3071.115 (Official Build) (64-bit)
Other information
Note 1
This potentially breaks adapters that use this function:
Note 2
The current implementation suggests that the function should return current window location if it fails to reach the top window location. However,
window.top.location
returns an exception object instead of throwing an error; hence, the catch block was unreachable.The text was updated successfully, but these errors were encountered: