-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add coingecko_id
to asset metadata
#121
Comments
managed to get a free API key, querying the coingecko api automatically now. also here's all of their supported coins in a gsheet: https://docs.google.com/spreadsheets/d/1wTTuxXt8n9q7C4NDXqQpI3wpKu1_5bGVmP9Xz0XGSyU/edit?gid=0#gid=0 |
|
Extends the `Inner` struct in `denom_metadata.rs` to include a `coingecko_id` field. Updates related methods to handle the new field, including `From`, `TryFrom`, `Debug`, and default initialization. ## Issue ticket number and link prax-wallet/registry#121 ## Checklist before requesting a review - [x] I have added guiding text to explain how a reviewer should test these changes. - [x] If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:
In penumbra-zone/penumbra#5000 we added a
coingecko_id
to theMetadata
proto. Now, we should augment thepenumbra-1
registry entries with an associated id:This will let us amend and merge penumbra-zone/penumbers#16 which was kindly done for us.
This means we have to:
It would be very helpful to document each steps to facilitate collaborations with other teams
The text was updated successfully, but these errors were encountered: