Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proto(asset): add coingecko_id to Metadata #5000

Merged
merged 3 commits into from
Jan 23, 2025
Merged

Conversation

erwanor
Copy link
Member

@erwanor erwanor commented Jan 22, 2025

Describe your changes

This PR adds a field to core.asset.v1.Metadata to optionally augment registry asset with a coingecko_id

Issue ticket number and link

#4998

Checklist before requesting a review

  • I have added guiding text to explain how a reviewer should test these changes.

  • If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:

    Proto change

@erwanor erwanor added the protobuf-changes Makes changes to the protobuf definitions. label Jan 22, 2025
@erwanor erwanor requested a review from conorsch January 22, 2025 22:35
@erwanor erwanor self-assigned this Jan 22, 2025
Copy link
Contributor

@cronokirby cronokirby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should do what it says on the tin

@conorsch conorsch merged commit 871551b into main Jan 23, 2025
15 checks passed
@conorsch conorsch deleted the erwan/4998_metadata_proto branch January 23, 2025 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protobuf-changes Makes changes to the protobuf definitions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants