Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ground disconnector and ground in FlatDesignLibrary #602

Merged
merged 8 commits into from
Apr 4, 2024
Merged

Conversation

flo-dup
Copy link
Contributor

@flo-dup flo-dup commented Apr 3, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?
No

What kind of change does this PR introduce?
Bug fix

What is the current behavior?
Grounds/ground disconnectors have display bugs when using FlatDesignLibrary (stroke width thicker than other equipments/wires, ground displayed above the wire, wire continuing behind ground disconnector)

What is the new behavior (if this is a feature change)?
Display bugs fixed

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

flo-dup added 8 commits April 3, 2024 16:49
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup flo-dup requested a review from So-Fras April 3, 2024 14:53
Copy link

sonarqubecloud bot commented Apr 3, 2024

@So-Fras So-Fras merged commit 1c56723 into main Apr 4, 2024
6 checks passed
@So-Fras So-Fras deleted the ground_flat branch April 4, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants