Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Babel 6.x support #5

Merged
merged 53 commits into from
Nov 13, 2015
Merged

Babel 6.x support #5

merged 53 commits into from
Nov 13, 2015

Conversation

twada
Copy link
Member

@twada twada commented Oct 30, 2015

Wrestling with Babel6

  • update dependencies
  • dealing with Plugin API changes
  • dealing with internal SPI changes
  • dealing with tree node type changes
  • wrestling with Babel6 presets-es2015
  • wrestling with Babel6 presets-stage-3
  • make it work
  • back to all green
  • remove dirty hacks
  • make it right
  • make it fast (if possible)
  • README
  • CHANGELOG for 2.0.0
  • field test

fixes #4

@twada twada mentioned this pull request Oct 31, 2015
Merged
@twada
Copy link
Member Author

twada commented Oct 31, 2015

Doesn't work with babel-preset-es2015 yet since Babel6 plugin runs AFTER presets ?

@twada twada mentioned this pull request Oct 31, 2015
Closed
@twada
Copy link
Member Author

twada commented Nov 2, 2015

AVA is upgrading to Babel 6.
Should not keep AVA guys waiting long.

twada added 9 commits November 4, 2015 16:05
@twada
chore(package): update espower to 1.1.0
14d8dd0
@twada
test(babel-plugin-espower): add transforms individually for debugging
198e325
@twada
chore(babel-plugin-espower): using babel's NodePath instead of array …
dfb95fc 
…of paths (espath)
@twada
chore(babel-plugin-espower): store original espath by ahead of time t…
7817a7c 
…raversing

It's a mega hack.
@twada
chore(babel-plugin-espower): expected output under presets-es2015
ff21a4d
@twada
chore(babel-plugin-espower): comment debugging code out
29d58a2
@twada
Merge branch 'presets-es2015' into babel6
f369b0b
@twada
test(babel-plugin-espower): TaggedTemplateExpression output with pres…
6b61ddf 
…ets-es2015
@twada
fix(babel-plugin-espower): store NodePath as a flag of skipping espow…
bf25056 
…er processing

but do not call NodePath#skip to not to interrupt other transformers
@jamestalmage
Copy link
Contributor

@twada

Did you see this comment: babel/babel#2648 (comment)

You should be able to work with presets and plugins like this:

{
  "presets": [
    {
      "plugins": [
        "transform-foo",
        "transform-bar"
      ]
    },
    "es2015"
  ]
}

twada added 19 commits November 12, 2015 12:22
@twada
refactor(babel-plugin-espower): remove dirty hacks
edf2f41
@twada
feat(babel-plugin-espower): re-support capturing of YieldExpression a…
c3238f1 
…nd AwaitExpression
@twada
style(babel-plugin-espower): styling and remove consoles
05142b9
@twada
refactor(babel-plugin-espower): use hidden property to mark generated…
bf9d797 
… node to avoid extra traversal
@twada
refactor(babel-plugin-espower): combine conditionals
4920139
@twada
refactor(babel-plugin-espower): make it clear to capture argument if …
0a4448a 
…and only if modified
@twada
docs(README): docs for Babel 6.x support
0be1089
@twada
refactor(babel-plugin-espower): flatten conditionals
fa0ed42
@twada
docs(CHANGELOG): add CHANGELOG for 2.0.0
ae5b295
@twada
refactor(babel-plugin-espower): inline variable
a9c6db8
@twada
docs(README): docs for Babel 6.x, presets and .babelrc
be002c8
@twada
docs(README): update examples
b8bd94e
@twada
chore(travis): add Node 4.2 CI build
d9acc98
@twada
refactor(babel-plugin-espower): simplify type predicates
f9b870b
@twada
refactor(babel-plugin-espower): intention revealing names
0dd52d4
@twada
chore(babel-plugin-espower): does not have to skip since generated pa…
f9f0141 
…rent node will be skipped on revisit
@twada
docs(README): update babelify usage
a3ea77b
@twada
test(babel-plugin-espower): adjust expected output with latest babel
b5f0927
@twada
chore(package): respect semver range of babel-generator
5d57824
@twada twada changed the title [WIP] Babel 6.x support Babel 6.x support Nov 13, 2015
twada added a commit that referenced this pull request Nov 13, 2015
@twada
Merge pull request #5 from power-assert-js/babel6
72a0ec1 
Babel 6.x support
@twada twada merged commit 72a0ec1 into master Nov 13, 2015
@jamestalmage
Copy link
Contributor

WOOOT!
👏 👍

// @sindresorhus

@twada
Copy link
Member Author

twada commented Nov 13, 2015

@jamestalmage Thanks!!

@twada twada deleted the babel6 branch November 13, 2015 05:39
@sindresorhus
Copy link

Awesome work people! :)

@twada
Copy link
Member Author

twada commented Nov 16, 2015

@sindresorhus That was a tough one ;)
I'm looking forward to seeing AVA running with Babel6 !

@sindresorhus
Copy link

@jamestalmage is working on it in avajs/ava#212.

@twada
Copy link
Member Author

twada commented Nov 16, 2015

Thanks @jamestalmage !

@jamestalmage
Copy link
Contributor

@jamestalmage is working on it in avajs/ava#212.

as we speak!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Babel 6.x support
3 participants
@twada @jamestalmage @sindresorhus