Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - Babel 6 upgrade #212

Closed
wants to merge 0 commits into from
Closed

Conversation

jamestalmage
Copy link
Contributor

This works but Babel is really slow.

Also, I think there are some problems with the latest babel-plugin-transform-runtime that required me to pin back a minor release.

babel/babel#2954

"babel-plugin-transform-runtime": "^6.1.18",
"babel-preset-es2015": "6.0.14",
"babel-preset-stage-3": "6.0.14",
"babel-runtime": "^5.8.34",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@floatdrop I think the reason I need to depend on babel-runtime@5 here is because of the way we are mucking with module paths. Many of babels transforms depend on babel-runtime@5 internally, so I think our hack is forcing unintentionally pushing them back to v6.

That's my best guess right now anyways.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the reason I need to depend on babel-runtime@5 here is because of the way we are mucking with module paths

This may not be true. I just discovered that running the babel test suite had created a whole bunch of global symlinks. Not sure if it was what was causing this, I will retest later.

@jamestalmage
Copy link
Contributor Author

Babel 6 has crazy long bootup.
#148 and #182 are going to become really important.

@sindresorhus
Copy link
Member

Babel 6 has crazy long bootup.

Oh, that sucks... You might want to open an issue on Babel about it. You can use time-require to see what's slowing it down.

@jamestalmage
Copy link
Contributor Author

@jamestalmage
Copy link
Contributor Author

Never Mind:

npm dedupe improves babel 6 times drastically.

I still had npm@2 lying around in my node 4.1.2 install

So it seems you trade a longer npm install, for faster requires. Worth it, it seems to me.

@sindresorhus
Copy link
Member

Cool, I guess it's fine then :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants