Add interruptPrompt() method
#803
Conversation
extensions/positron-r/src/runtime.ts
Outdated
| @@ -76,6 +76,14 @@ export class RRuntime implements positron.LanguageRuntime, vscode.Disposable { | |||
| this._kernel.replyToPrompt(id, reply); | |||
| } | |||
|
|
|||
| async interruptPrompt(id: string): Promise<void> { | |||
| if (this._kernel.interruptPrompt) { | |||
| await this._kernel.interruptPrompt!(id); | |||
There was a problem hiding this comment.
Nit, here and elsewhere -- the ! assertion shouldn't be necessary inside an if block that tests to ensure the method exists
There was a problem hiding this comment.
That's what I was expecting too but the LSP (or was it ESlint?) didn't seem to agree.
src/positron-dts/positron.d.ts
Outdated
| @@ -442,6 +442,11 @@ declare module 'positron' { | |||
| /** Reply to a prompt issued by the runtime */ | |||
| replyToPrompt(id: string, reply: string): void; | |||
|
|
|||
| /** Interrupt a prompt issued by the runtime. If not implemented, | |||
| * `interrupt()` is called instead. | |||
There was a problem hiding this comment.
Nit: spacing, the * should be on the same line as the leading * on the previous line for the comment documentation parser to work correctly
hmm... I thought this layer was responsible for multiple kernels but looking more closely that's not the case. Since there can only be one active input request at a time IIUC, do we need that |
abf3d16 to
aca1af1
Compare
aca1af1 to
ee08ac0
Compare
Related to #535.
Interrupting a prompt request from the backend requires updating some state in JupyterKernel. To support this, a new
interruptPrompt()is added to theLanguageRuntimeinterface.This new method is optional. If not implemented,
interrupt()is called just as before.