Downgrade node-gyp-build for Jupyter Adapter #4439
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For reasons that we haven't yet fully ascertained, Jupyter Adapter builds are broken on Windows for dev environments, after #4283.
After some investigation, it appears we're hitting prebuild/node-gyp-build#71 (caused by prebuild/node-gyp-build@692860e), which is still unresolved in node-gyp-build 4.8.1.
The fix is to downgrade node-gyp-build to 4.8.0 for the Jupyter Adapter, which is an older version that doesn't contain the offending commit.
Note
I also tried downgrading node-gyp-build to 4.8.0 across Positron, but it turns out that other places only work with 4.8.1. What a delight.