Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade node-gyp-build for Jupyter Adapter #4439

Merged
merged 3 commits into from
Aug 22, 2024

Conversation

jmcphers
Copy link
Collaborator

@jmcphers jmcphers commented Aug 21, 2024

For reasons that we haven't yet fully ascertained, Jupyter Adapter builds are broken on Windows for dev environments, after #4283.

error C:\Users\jmcph\git\positron\extensions\jupyter-adapter\node_modules\lzma-native: Command failed.
Exit code: 1
Command: node-gyp-build
Arguments:
Directory: C:\Users\jmcph\git\positron\extensions\jupyter-adapter\node_modules\lzma-native
Output:
'C:\Program' is not recognized as an internal or external command,
operable program or batch file.

After some investigation, it appears we're hitting prebuild/node-gyp-build#71 (caused by prebuild/node-gyp-build@692860e), which is still unresolved in node-gyp-build 4.8.1.

The fix is to downgrade node-gyp-build to 4.8.0 for the Jupyter Adapter, which is an older version that doesn't contain the offending commit.

Note

I also tried downgrading node-gyp-build to 4.8.0 across Positron, but it turns out that other places only work with 4.8.1. What a delight.

@jmcphers jmcphers requested a review from lionel- August 21, 2024 23:08
Copy link
Contributor

@jonvanausdeln jonvanausdeln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the issue on my windows box!

@petetronic petetronic merged commit 2a51e69 into main Aug 22, 2024
2 checks passed
@petetronic petetronic deleted the bugfix/node-gyp-build-4.8.0 branch August 22, 2024 12:37
@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants