Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Downgrade node-gyp-build for Jupyter Adapter (#4439)
For reasons that we haven't yet fully ascertained, Jupyter Adapter builds are broken on Windows for dev environments, after #4283. ``` error C:\Users\jmcph\git\positron\extensions\jupyter-adapter\node_modules\lzma-native: Command failed. Exit code: 1 Command: node-gyp-build Arguments: Directory: C:\Users\jmcph\git\positron\extensions\jupyter-adapter\node_modules\lzma-native Output: 'C:\Program' is not recognized as an internal or external command, operable program or batch file. ``` After some investigation, it appears we're hitting prebuild/node-gyp-build#71 (caused by prebuild/node-gyp-build@692860e), which is still unresolved in node-gyp-build 4.8.1. The fix is to downgrade node-gyp-build to 4.8.0 for the Jupyter Adapter, which is an older version that doesn't contain the offending commit. > [!NOTE] > I also tried downgrading node-gyp-build to 4.8.0 across Positron, but it turns out that other places _only_ work with 4.8.1. What a delight.
- Loading branch information