Skip to content

Commit

Permalink
Downgrade node-gyp-build for Jupyter Adapter (#4439)
Browse files Browse the repository at this point in the history
For reasons that we haven't yet fully ascertained, Jupyter Adapter
builds are broken on Windows for dev environments, after #4283.

```
error C:\Users\jmcph\git\positron\extensions\jupyter-adapter\node_modules\lzma-native: Command failed.
Exit code: 1
Command: node-gyp-build
Arguments:
Directory: C:\Users\jmcph\git\positron\extensions\jupyter-adapter\node_modules\lzma-native
Output:
'C:\Program' is not recognized as an internal or external command,
operable program or batch file.
```

After some investigation, it appears we're hitting
prebuild/node-gyp-build#71 (caused by
prebuild/node-gyp-build@692860e),
which is still unresolved in node-gyp-build 4.8.1.

The fix is to downgrade node-gyp-build to 4.8.0 for the Jupyter Adapter,
which is an older version that doesn't contain the offending commit.

> [!NOTE]
> I also tried downgrading node-gyp-build to 4.8.0 across Positron, but
it turns out that other places _only_ work with 4.8.1. What a delight.
  • Loading branch information
jmcphers authored Aug 22, 2024
1 parent 22dcca6 commit 2a51e69
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion extensions/jupyter-adapter/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,6 @@
"url": "https://github.com/posit-dev/positron"
},
"resolutions": {
"node-gyp-build": "4.8.1"
"node-gyp-build": "4.8.0"
}
}
8 changes: 4 additions & 4 deletions extensions/jupyter-adapter/yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -932,10 +932,10 @@ node-api-version@^0.1.4:
dependencies:
semver "^7.3.5"

node-gyp-build@4.8.1, node-gyp-build@^4.2.1:
version "4.8.1"
resolved "https://registry.yarnpkg.com/node-gyp-build/-/node-gyp-build-4.8.1.tgz#976d3ad905e71b76086f4f0b0d3637fe79b6cda5"
integrity sha512-OSs33Z9yWr148JZcbZd5WiAXhh/n9z8TxQcdMhIOlpN9AhWpLfvVFO73+m77bBABQMaY9XSvIa+qk0jlI7Gcaw==
node-gyp-build@4.8.0, node-gyp-build@^4.2.1:
version "4.8.0"
resolved "https://registry.yarnpkg.com/node-gyp-build/-/node-gyp-build-4.8.0.tgz#3fee9c1731df4581a3f9ead74664369ff00d26dd"
integrity sha512-u6fs2AEUljNho3EYTJNBfImO5QTo/J/1Etd+NVdCj7qWKUSN/bSLkZwhDv7I+w/MSC6qJ4cknepkAYykDdK8og==

node-gyp@^9.0.0:
version "9.3.1"
Expand Down

0 comments on commit 2a51e69

Please sign in to comment.