Remove Prod-Pipes PAT #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Repo is no longer private, and this expired token is crashing the deploy workflow
|
useful thread actions/checkout#664 |
jmarshall
approved these changes
Nov 6, 2023
| @@ -87,8 +87,6 @@ jobs: | |||
| ref: "main" | |||
| path: "production-pipelines" | |||
| submodules: recursive | |||
| # Comment this line out to revert to using the default $GITHUB_TOKEN. | |||
| token: ${{ secrets.PRODUCTION_PIPELINES_RAW_REPO_TOKEN }} | |||
There was a problem hiding this comment.
I think this is the one I was expecting to stop working when this token expired. The others can fall back to unauthenticated access to now-public repositories, but not this one that's explicitly setting an action's token parameter.
So that this remains a hint for next time we have to make that repo private (hopefully never happens, but it's hard to make predictions about the future), I'd rather this was just commented out and the comment I guess updated to something like Uncomment this line and set up a PAT if production-pipelines needs to be taken private.
There was a problem hiding this comment.
fair comment, I'll do that instead!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repo is no longer private, and this expired token is crashing the deploy workflow
Also bumps the gcloud setup workflow which is available at
V1https://github.com/marketplace/actions/set-up-gcloud-cloud-sdk-environment