-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign #203
Redesign #203
Conversation
Absolutely brilliant! |
This looks really good!
I'll test it out with a Parity Signer account tomorrow :) |
Play-through review -
|
# Conflicts: # lerna.json # package.json # packages/extension-chains/package.json # packages/extension-dapp/package.json # packages/extension-inject/package.json # packages/extension-ui/package.json # packages/extension-ui/src/Popup/Signing/Extrinsic.tsx # packages/extension-ui/src/Popup/Signing/Request.tsx # packages/extension-ui/src/components/contexts.tsx # packages/extension/package.json
* delete print button and change cancel to back button
skip-checks: true
# Conflicts: # lerna.json # package.json # packages/extension-chains/package.json # packages/extension-dapp/package.json # packages/extension-inject/package.json # packages/extension-ui/package.json # packages/extension/package.json
This is exactly what I wanted to test, thanks for seeing this, and sorry for my lack of test early on. Tested the extension again with Signer. My (rather old) phone still has problems to read the QR code in dark mode, I'd go for a little more than 1px on the img border to make it even simpler: here Found some nits, but honestly the experience is great:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks an absolute million. Really excited to have this and moving thing forward.
As discussed, will log some issues for the not-new issues and anything that may pop-up.
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Update the extension look and feel and UX to be more pleasant and smooth to work with.