Refactor button and mnemonic #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
09750ed to
31d3045
Compare
31d3045 to
f62d26c
Compare
krzysztof-jelski
approved these changes
Nov 22, 2019
| @@ -50,7 +50,6 @@ export default function ImportQr (): React.ReactElement<Props> { | |||
| {name && ( | |||
| <ButtonArea> | |||
| <Button | |||
| label='Add the account with identified address' | |||
There was a problem hiding this comment.
Was it not showing in the UI at all? It's a graphics-only button, right? Maybe we should show it in the alt text.
591e29b to
4fff20e
Compare
vanruch
added a commit
that referenced
this pull request
Dec 20, 2019
* Inject theme using styled-components' ThemeProvider (#3) * Apply colors from design, styles refactoring (#5) * Add new tip and accounts screen without accounts (#7) * Sync with upstream (#10) * Use Nunito font (#11) * Create account first page (#14) * Customizable identicon (#13) * Inline buttons (#16) * Welcome screen styling (#17) * Account creation second step (#15) * Add new header (#20) * change welcome screen (#19) * Account screen (#18) * Update from upstream (#21) * Window title (#25) * New authorize (#24) * Refactor and remove unnecessary stuff from theme (#22) * refactor add accounts screen (#29) * Export and forget screens, change general padding to 24px (#27) * Signing screen (#26) * Import account screens (#31) * Change header with settings (#28) * Refactor button and mnemonic (#30) * Restyle checkbox (#33) * Remove opacity from background; add borders (#32) * Code style polishing (#34) * Move fileMock to __mocks__ (#35) * Add light theme (#36) * Small design changes (#38) * Change background color (#39) * Sync with upstream (#41) * Update screenshots in readme * [CI Skip] 0.14.0-beta.7 skip-checks: true * fix error for display menu (#42) * fix display of authorization (#43) * firefox scrol (#45) * small change for rename account (#44) * Sync with upstream * Print and back button (#48) * delete print button and change cancel to back button * Set body color (#49) * Fix the fix of account rename (#52) * Update generic sign screen (#47) * Improve UI/UX design (#53) * [CI Skip] 0.14.0-beta.10 skip-checks: true * Improve QR code recognition on dark theme (#54) * Add proper tx/sign texts and headers (#55) Co-authored-by: Kamil Dąbrowski <kamil@ethworks.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.