Reorder read csv args #2026
Merged
Reorder read csv args #2026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1c789c8 to
726d597
Compare
726d597 to
7ba597d
Compare
ghuls
commented
Dec 10, 2021
| if columns: | ||
| if isinstance(columns, list): | ||
| if all(isinstance(i, int) for i in columns): | ||
| projection = columns # type: ignore |
There was a problem hiding this comment.
@zundertj Do you know a way to tell mypy that columns canl only be List[int] at this point?
There was a problem hiding this comment.
Apologies, had been working on other projects. I have put a PR.
… argument mapping for renamed arguments.
zundertj
added a commit
to zundertj/polars
that referenced
this pull request
Dec 21, 2021
As per the question of @ghuls at pola-rs#2026 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.