Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update call to pl.read_csv #57

Closed
dburkhardt opened this issue Jan 30, 2023 · 2 comments
Closed

Update call to pl.read_csv #57

dburkhardt opened this issue Jan 30, 2023 · 2 comments

Comments

@dburkhardt
Copy link
Contributor

dburkhardt commented Jan 30, 2023 •
edited
Loading

pycisTopic/pycisTopic/utils.py

Line 397 in 242c2a4

has_headers=False,

This code is no longer up to date with polars. The current code has a parameter has_header not has_headers.

See https://pola-rs.github.io/polars/py-polars/html/reference/api/polars.read_csv.html
@dburkhardt
Copy link
Contributor Author

Looks like this was introduced with pola-rs/polars@4af49ae in pola-rs/polars#2026

@dburkhardt
Copy link
Contributor Author

Confirmed the API changed in v0.11 on PyPI: https://pypi.org/project/polars/0.11.0/#files

dburkhardt added a commit to dburkhardt/pycisTopic that referenced this issue Jan 30, 2023
@dburkhardt
Fix aertslab#57 - update pl.read_csv
970ef10
@dburkhardt dburkhardt mentioned this issue Jan 30, 2023
Merged
cbravo93 added a commit that referenced this issue Jan 31, 2023
@cbravo93
Merge pull request #58 from dburkhardt/master
219225d 
Update pl.read_csv call (#57) + peak_calling bugfix (#61)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dburkhardt @cbravo93