Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4557 ndc thread local #4682

Merged
merged 9 commits into from
Sep 12, 2024
Merged

Conversation

siren186
Copy link
Member

@siren186 siren186 commented Sep 12, 2024

Replacement for PR: #4674

  1. Fix NestedDiagnosticContext should be thread local #4557
  2. Merged dump(bool nameOnly) function from implemented here
  3. Discard backtrace from implemented here . Because it can be replaced with a more powerful implementation by Boost.Stacktrace

@siren186 siren186 mentioned this pull request Sep 12, 2024
@aleks-f
Copy link
Member

aleks-f commented Sep 12, 2024

  1. Discard backtrace from implemented here . Because it can be replaced with a more powerful implementation by Boost.Stacktrace

Only if you plan to rewrite it in poco style; we will not introduce boost dependency

@siren186
Copy link
Member Author

siren186 commented Sep 12, 2024

@aleks-f Rewrite boost::stacktrace in poco style is complex. I think current PR is not fit to solve the problem.
For me import both Boost and Poco in my application is a better chioce.
If there is a fate in the future, I will implement it and create another PR to solve the problem.

@aleks-f aleks-f merged commit 71a9bda into pocoproject:main Sep 12, 2024
33 checks passed
@siren186 siren186 deleted the fix/NestedDiagnosticContext branch September 12, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NestedDiagnosticContext should be thread local
2 participants