Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NestedDiagnosticContext should be thread local #4557

Closed
siren186 opened this issue May 14, 2024 · 0 comments · Fixed by #4682
Closed

NestedDiagnosticContext should be thread local #4557

siren186 opened this issue May 14, 2024 · 0 comments · Fixed by #4682
Labels
bug fixed
Milestone
Release 1.14.0

Comments

@siren186
Copy link
Member

siren186 commented May 14, 2024 •
edited
Loading

Describe the bug
A clear and concise description of what the bug is.

NestedDiagnosticContext& NestedDiagnosticContext::current()
{
	static NestedDiagnosticContext ndc;
	return ndc;
}

It should use Thread Local Storage to store the NDC context. Not a singleton.

Please add relevant environment information:

  • Windows 10
  • poco-1.13.3
@siren186 siren186 added the bug label May 14, 2024
@aleks-f aleks-f added this to the Release 1.14.0 milestone May 14, 2024
@aleks-f aleks-f added this to 1.14 May 14, 2024
@siren186 siren186 mentioned this issue Sep 6, 2024
Closed
@aleks-f aleks-f mentioned this issue Sep 11, 2024
Closed
@aleks-f aleks-f changed the title NestedDiagnosticContext crashed in multi-thread environment NestedDiagnosticContext should be thread local Sep 11, 2024
@aleks-f aleks-f moved this to In Progress in 1.14 Sep 11, 2024
@aleks-f aleks-f added the fixed label Sep 11, 2024
@siren186 siren186 mentioned this issue Sep 12, 2024
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in 1.14 Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug fixed
Projects
1.14
Status: Done
Milestone
Release 1.14.0
2 participants
@aleks-f @siren186